Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(eos_cli_config_gen)!: Avoid generating invalid configuration for traffic policies #4266

Merged
merged 32 commits into from
Sep 24, 2024

Conversation

MaheshGSLAB
Copy link
Contributor

@MaheshGSLAB MaheshGSLAB commented Jul 26, 2024

Change Summary

Added test in molecule for traffic policies to improve the coverage plus fix the j2 template

Related Issue(s)

Fixes #

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

Added test in molecule for traffic policies to improve the coverage.
Updated the J2 template for eos and documentation to fix the coverage issue and render doc correctly.

How to test

Run molecule

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@MaheshGSLAB MaheshGSLAB self-assigned this Jul 26, 2024
@github-actions github-actions bot added the state: CI Updated CI scenario have been updated in the PR label Jul 26, 2024
Copy link

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4266
# Activate the virtual environment
source test-avd-pr-4266/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/MaheshGSLAB/ansible-avd.git@traffic-policies#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/MaheshGSLAB/ansible-avd.git#/ansible_collections/arista/avd/,traffic-policies --force
# Optional: Install AVD examples
cd test-avd-pr-4266
ansible-playbook arista.avd.install_examples

@MaheshGSLAB MaheshGSLAB marked this pull request as ready for review July 29, 2024 10:50
@MaheshGSLAB MaheshGSLAB requested review from a team as code owners July 29, 2024 10:50
@MaheshGSLAB MaheshGSLAB marked this pull request as draft July 30, 2024 12:16
@MaheshGSLAB MaheshGSLAB marked this pull request as ready for review July 30, 2024 14:30
Copy link
Contributor

@gmuloc gmuloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this - this coverage just allowed to show that there is a problem in the code

Change the PR title to a Fix, keep your extra coverage and let's adjust the doc template to render correcly

@MaheshGSLAB MaheshGSLAB changed the title Test(eos_cli_config_gen): Added test in molecule for traffic policies to improve the coverage Fix(eos_cli_config_gen): Added test in molecule for traffic policies to improve the coverage plus fix the j2 template Aug 2, 2024
@MaheshGSLAB MaheshGSLAB marked this pull request as draft August 7, 2024 07:14
Copy link
Contributor

@Shivani-gslab Shivani-gslab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@laxmikantchintakindi
Copy link
Contributor

LGTM

@ClausHolbechArista ClausHolbechArista changed the title Fix(eos_cli_config_gen): Added test in molecule for traffic policies to improve the coverage plus fix the j2 template Fix(eos_cli_config_gen)!: Avoid generating invalid configuration for traffic policies Sep 17, 2024
@ClausHolbechArista ClausHolbechArista added this to the v5.0.0 milestone Sep 18, 2024
@ClausHolbechArista
Copy link
Contributor

Needs a rerun of eos_cli_config_gen molecule.

@MaheshGSLAB
Copy link
Contributor Author

Needs a rerun of eos_cli_config_gen molecule.

Done, and coverage is also 100%

Copy link

@gmuloc gmuloc merged commit b61dc52 into aristanetworks:devel Sep 24, 2024
43 checks passed
@Shivani-gslab Shivani-gslab mentioned this pull request Oct 18, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rn: Fix(eos_cli_config_gen)! role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated type: documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants