-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix(eos_cli_config_gen)!: Avoid generating invalid configuration for traffic policies #4266
Conversation
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4266
# Activate the virtual environment
source test-avd-pr-4266/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/MaheshGSLAB/ansible-avd.git@traffic-policies#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/MaheshGSLAB/ansible-avd.git#/ansible_collections/arista/avd/,traffic-policies --force
# Optional: Install AVD examples
cd test-avd-pr-4266
ansible-playbook arista.avd.install_examples |
...ble_collections/arista/avd/molecule/eos_cli_config_gen/intended/configs/traffic-policies.cfg
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_cli_config_gen/j2templates/documentation/traffic-policies.j2
Outdated
Show resolved
Hide resolved
be3ab88
to
4eee0c4
Compare
python-avd/pyavd/_eos_cli_config_gen/j2templates/eos/traffic-policies.j2
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this - this coverage just allowed to show that there is a problem in the code
Change the PR title to a Fix, keep your extra coverage and let's adjust the doc template to render correcly
...collections/arista/avd/molecule/eos_cli_config_gen/documentation/devices/traffic-policies.md
Outdated
Show resolved
Hide resolved
...collections/arista/avd/molecule/eos_cli_config_gen/documentation/devices/traffic-policies.md
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_cli_config_gen/j2templates/documentation/traffic-policies.j2
Show resolved
Hide resolved
...collections/arista/avd/molecule/eos_cli_config_gen/documentation/devices/traffic-policies.md
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_cli_config_gen/j2templates/eos/traffic-policies.j2
Show resolved
Hide resolved
python-avd/pyavd/_eos_cli_config_gen/j2templates/eos/traffic-policies.j2
Show resolved
Hide resolved
python-avd/pyavd/_eos_cli_config_gen/j2templates/eos/traffic-policies.j2
Show resolved
Hide resolved
python-avd/pyavd/_eos_cli_config_gen/j2templates/eos/traffic-policies.j2
Show resolved
Hide resolved
python-avd/pyavd/_eos_cli_config_gen/j2templates/documentation/traffic-policies.j2
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_cli_config_gen/j2templates/documentation/traffic-policies.j2
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_cli_config_gen/j2templates/documentation/traffic-policies.j2
Show resolved
Hide resolved
7f67832
to
0dd2dde
Compare
python-avd/pyavd/_eos_cli_config_gen/j2templates/eos/traffic-policies.j2
Outdated
Show resolved
Hide resolved
…olicies.j2 Co-authored-by: laxmikantchintakindi <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Many changes since then
LGTM |
...collections/arista/avd/molecule/eos_cli_config_gen/documentation/devices/traffic-policies.md
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_cli_config_gen/j2templates/documentation/traffic-policies.j2
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_cli_config_gen/j2templates/documentation/traffic-policies.j2
Outdated
Show resolved
Hide resolved
Needs a rerun of |
Done, and coverage is also 100% |
Quality Gate passedIssues Measures |
Change Summary
Added test in molecule for traffic policies to improve the coverage plus fix the j2 template
Related Issue(s)
Fixes #
Component(s) name
arista.avd.eos_cli_config_gen
Proposed changes
Added test in molecule for traffic policies to improve the coverage.
Updated the J2 template for eos and documentation to fix the coverage issue and render doc correctly.
How to test
Run molecule
Checklist
User Checklist
Repository Checklist