-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doc(eos_designs): Add warning about WAN BGP peer groups password #4265
Merged
ClausHolbechArista
merged 6 commits into
aristanetworks:devel
from
gmuloc:doc-wan-rr-overlay-peer-grouppassword
Jul 26, 2024
Merged
Doc(eos_designs): Add warning about WAN BGP peer groups password #4265
ClausHolbechArista
merged 6 commits into
aristanetworks:devel
from
gmuloc:doc-wan-rr-overlay-peer-grouppassword
Jul 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4265
# Activate the virtual environment
source test-avd-pr-4265/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/gmuloc/avd.git@doc-wan-rr-overlay-peer-grouppassword#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/gmuloc/avd.git#/ansible_collections/arista/avd/,doc-wan-rr-overlay-peer-grouppassword --force
# Optional: Install AVD examples
cd test-avd-pr-4265
ansible-playbook arista.avd.install_examples |
github-actions
bot
added
state: Documentation role Updated
role: eos_designs
issue related to eos_designs role
labels
Jul 26, 2024
ansible_collections/arista/avd/roles/eos_designs/docs/how-to/wan.md
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/roles/eos_designs/docs/how-to/wan.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Claus Holbech <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please bring the schema descriptions in sync with the updated how-to warning.
python-avd/pyavd/_eos_designs/schema/schema_fragments/bgp_peer_groups.schema.yml
Show resolved
Hide resolved
Quality Gate passedIssues Measures |
ClausHolbechArista
approved these changes
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
rn: Doc(eos_designs)
role: eos_designs
issue related to eos_designs role
state: Documentation role Updated
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Document some known issue for BGP peer group passwords
Component(s) name
arista.avd.eos_designs
Proposed changes
text about WAN BGP peer group passwords
How to test
no test
Checklist
Repository Checklist