Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor(eos_cli_config_gen): Add primary key for connectivity monitor hosts #4264

Merged
merged 2 commits into from
Jul 26, 2024

Conversation

gmuloc
Copy link
Contributor

@gmuloc gmuloc commented Jul 25, 2024

Change Summary

enhance model with primary key

Related Issue(s)

Fixes #4263

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

Add primary_key: name for hosts outside and inside VRFs for connectivity monitors

How to test

Cannot have the same host twice (no molecule test)

Check on EOS device that same name can be reused across VRFs

monitor connectivity
   vrf TITI
      host BLAH
         icmp echo size 42
   !
   vrf TOTO
      host BLAH
         name-server group dddddd
         icmp echo size 42
   !
   host BLAH
      icmp echo size 42

Checklist

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@gmuloc gmuloc requested review from a team as code owners July 25, 2024 15:52
Copy link

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4264
# Activate the virtual environment
source test-avd-pr-4264/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/gmuloc/avd.git@issue/4263#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/gmuloc/avd.git#/ansible_collections/arista/avd/,issue/4263 --force
# Optional: Install AVD examples
cd test-avd-pr-4264
ansible-playbook arista.avd.install_examples

@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: Documentation role Updated labels Jul 25, 2024
Copy link

@ClausHolbechArista ClausHolbechArista added the one approval This PR has one approval and is only missing one more. label Jul 26, 2024
@ClausHolbechArista ClausHolbechArista requested a review from a team July 26, 2024 05:20
Copy link
Contributor

@Shivani-gslab Shivani-gslab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ClausHolbechArista ClausHolbechArista merged commit 410b7b5 into aristanetworks:devel Jul 26, 2024
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
one approval This PR has one approval and is only missing one more. rn: Refactor(eos_cli_config_gen) role: eos_cli_config_gen issue related to eos_cli_config_gen role state: Documentation role Updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add primary_key in schema for monitor connectivity host
3 participants