Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(eos_cli_config_gen): SyncE support #4255

Merged
merged 12 commits into from
Jul 25, 2024

Conversation

colinmacgiolla
Copy link
Contributor

Change Summary

Add configuration support for Synchronous Ethernet

Related Issue(s)

Fixes #4231

Component(s) name

arista.avd.pyavd.eos_cli_config_gen

Proposed changes

Creation of a new sync_e model to enable the feature globally

sync_e:
   network_option: <1 | 2>

Modification to the existing ethernet_interfaces model:

ethernet_interfaces:
   Ethernet<X>:
      sync_e:
         enabled: <true | false >
         priority: <disabled, (int)1-255>

How to test

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated labels Jul 24, 2024
Copy link

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4255
# Activate the virtual environment
source test-avd-pr-4255/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/colinmacgiolla/ansible-avd.git@sync_e_support#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/colinmacgiolla/ansible-avd.git#/ansible_collections/arista/avd/,sync_e_support --force
# Optional: Install AVD examples
cd test-avd-pr-4255
ansible-playbook arista.avd.install_examples

@colinmacgiolla colinmacgiolla marked this pull request as ready for review July 24, 2024 14:21
@colinmacgiolla colinmacgiolla requested review from a team as code owners July 24, 2024 14:22
@ClausHolbechArista ClausHolbechArista added this to the v4.10.0 milestone Jul 25, 2024
Copy link
Contributor

@ClausHolbechArista ClausHolbechArista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@ClausHolbechArista ClausHolbechArista added the one approval This PR has one approval and is only missing one more. label Jul 25, 2024
Copy link

@ClausHolbechArista ClausHolbechArista merged commit 147eb9f into aristanetworks:devel Jul 25, 2024
44 checks passed
@colinmacgiolla colinmacgiolla deleted the sync_e_support branch October 18, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
one approval This PR has one approval and is only missing one more. rn: Feat(eos_cli_config_gen) role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for Synchronous Ethernet configuration
3 participants