Refactor(eos_designs,eos_cli_config_gen): Deprecate type conversion from dict-of-dicts to list-of-dicts #4237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…from dict-of-dicts to list-of-dicts
ClausHolbechArista
changed the title
|
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4237
# Activate the virtual environment
source test-avd-pr-4237/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/ClausHolbechArista/avd.git@refactor/eos_designs/deprecate-dict-conversion#subdirectory=python-avd" --force
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/ClausHolbechArista/avd.git#/ansible_collections/arista/avd/,refactor/eos_designs/deprecate-dict-conversion --force
# Optional: Install AVD examples
cd test-avd-pr-4237
ansible-playbook arista.avd.install_examples |
github-actions
bot
added
the
type: documentation
ClausHolbechArista
changed the title
gmuloc
approved these changes
Jul 23, 2024
|
gmuloc
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Deprecate type conversion from dict-of-dicts to list-of-dicts
As noted in release-notes for AVD 4.0.0 and in the porting guide for 3.x -> 4.x upgrades the automatic conversion of dict-of-dicts to list-of-dicts will be removed in AVD 5.0.
Component(s) name
arista.avd.eos_designsarista.avd.eos_cli_config_genProposed changes
Adding deprecation warning if any conversions are happening.
How to test
Tested by running
molecule converge -s eos_designs_deprecated_varsProof:
https://github.com/aristanetworks/avd/actions/runs/10055082881/job/27790997106#step:6:297
Checklist
User Checklist
Repository Checklist