Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor(pyavd): Suppress warnings for cryptography >=43.0.0 #4235

Merged

Conversation

gmuloc
Copy link
Contributor

@gmuloc gmuloc commented Jul 22, 2024

Change Summary

Forward compatible import of tripleDES algo which was moved starting cryptgraphy version 43.0.0 - https://github.com/pyca/cryptography/blob/main/CHANGELOG.rst#4300---2024-07-20

Related Issue(s)

Reported from field

Component(s) name

pyavd

Proposed changes

Import from new location and if import error use old location

How to test

pytest passes

Checklist

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@gmuloc gmuloc requested review from a team as code owners July 22, 2024 09:26
Copy link

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4235
# Activate the virtual environment
source test-avd-pr-4235/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/gmuloc/avd.git@use-triple-DES-from-decrepit#subdirectory=python-avd" --force
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/gmuloc/avd.git#/ansible_collections/arista/avd/,use-triple-DES-from-decrepit --force
# Optional: Install AVD examples
cd test-avd-pr-4235
ansible-playbook arista.avd.install_examples

@ClausHolbechArista ClausHolbechArista requested a review from a team July 22, 2024 10:01
@ClausHolbechArista ClausHolbechArista added the one approval This PR has one approval and is only missing one more. label Jul 22, 2024
Copy link

@ClausHolbechArista ClausHolbechArista merged commit 644fbb0 into aristanetworks:devel Jul 22, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
one approval This PR has one approval and is only missing one more. rn: Refactor(pyavd)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants