Fix(eos_cli_config_gen): Sort IPsec SA, IKE policies and profiles #4227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4227
# Activate the virtual environment
source test-avd-pr-4227/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/gmuloc/avd.git@sort-ipsec-profiles-and-sa#subdirectory=python-avd" --force
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/gmuloc/avd.git#/ansible_collections/arista/avd/,sort-ipsec-profiles-and-sa --force
# Optional: Install AVD examples
cd test-avd-pr-4227
ansible-playbook arista.avd.install_examples |
github-actions
bot
added
the
state: CI Updated
ClausHolbechArista
requested changes
Jul 22, 2024
|
Moving to draft until 4.10 has been released. |
|
Please add to release-notes for 5.x.x that we have reordered config and mention the area. It will be a common section for everything we decide to reorder. |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
ClausHolbechArista
force-pushed
the
sort-ipsec-profiles-and-sa
branch
from
8b1a669 to
841f4a3
Compare
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
ClausHolbechArista
approved these changes
Aug 21, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Today these objects are not sorted and so not matching the EOS cli output
Related Issue(s)
Found in field
Component(s) name
arista.avd.eos_cli_config_genProposed changes
Adding sort for doc and eos template
How to test
molecule
Checklist
Repository Checklist