Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(eos_cli_config_gen): Add support for additional dot1x commands. #4191

Merged
merged 15 commits into from
Sep 12, 2024
Merged

Feat(eos_cli_config_gen): Add support for additional dot1x commands. #4191

merged 15 commits into from
Sep 12, 2024

Conversation

laxmikantchintakindi
Copy link
Contributor

@laxmikantchintakindi laxmikantchintakindi commented Jul 9, 2024 •
edited
Loading

Change Summary

Add support for additional dot1x commands.

Related Issue(s)

Fixes #4118

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

Need to support the following CLI commands.

Switch-level:

dot1x
   mac-based-auth radius av-pair user-name delimiter none lowercase

Interface-level:

interface Ethernet<ID>
  dot1x aaa unresponsive phone action traffic allow
  dot1x aaa unresponsive action traffic allow vlan <VID>
  dot1x mac based access-list

How to test

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 9, 2024

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4191
# Activate the virtual environment
source test-avd-pr-4191/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/laxmikantchintakindi/avd.git@additional_dot1x#subdirectory=python-avd" --force
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/laxmikantchintakindi/avd.git#/ansible_collections/arista/avd/,additional_dot1x --force
# Optional: Install AVD examples
cd test-avd-pr-4191
ansible-playbook arista.avd.install_examples

@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated labels Jul 9, 2024
@laxmikantchintakindi laxmikantchintakindi marked this pull request as ready for review July 11, 2024 05:56
@laxmikantchintakindi laxmikantchintakindi requested review from a team as code owners July 11, 2024 05:56
@laxmikantchintakindi laxmikantchintakindi force-pushed the additional_dot1x branch 2 times, most recently from 19b4587 to 3ba8917 Compare July 22, 2024 05:53
Shivani-gslab
Shivani-gslab reviewed Jul 25, 2024
View reviewed changes
Copy link
Contributor

@Shivani-gslab Shivani-gslab left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check for coverage improvement for ethernet_interfaces.dot1x in this PR

@laxmikantchintakindi laxmikantchintakindi force-pushed the additional_dot1x branch 2 times, most recently from 1a67696 to a71b650 Compare July 26, 2024 07:13
@laxmikantchintakindi laxmikantchintakindi marked this pull request as draft July 26, 2024 08:19
@laxmikantchintakindi laxmikantchintakindi marked this pull request as ready for review July 29, 2024 11:29
@github-actions github-actions bot added the state: conflict PR with conflict label Jul 31, 2024
@github-actions GitHub Actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the state: conflict PR with conflict label Jul 31, 2024
@github-actions GitHub Actions
Copy link

Conflicts have been resolved. A maintainer will review the pull request shortly.

@laxmikantchintakindi laxmikantchintakindi marked this pull request as draft August 8, 2024 09:25
@laxmikantchintakindi laxmikantchintakindi marked this pull request as ready for review August 12, 2024 13:11
@github-actions github-actions bot added the state: conflict PR with conflict label Aug 23, 2024
@github-actions GitHub Actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the state: conflict PR with conflict label Sep 10, 2024
@github-actions GitHub Actions
Copy link

Conflicts have been resolved. A maintainer will review the pull request shortly.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@ClausHolbechArista ClausHolbechArista merged commit cc346f5 into aristanetworks:devel Sep 12, 2024
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shivani-gslab Shivani-gslab Shivani-gslab approved these changes

@Vibhu-gslab Vibhu-gslab Vibhu-gslab left review comments

@MaheshGSLAB MaheshGSLAB MaheshGSLAB approved these changes

@ClausHolbechArista ClausHolbechArista ClausHolbechArista approved these changes

Assignees

@laxmikantchintakindi laxmikantchintakindi

Labels
rn: Feat(eos_cli_config_gen) role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support additional dot1x commands
5 participants
@laxmikantchintakindi @ClausHolbechArista @Vibhu-gslab @MaheshGSLAB @Shivani-gslab