Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(plugins): Fix deprecation warning after reformatting #4183

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

gmuloc
Copy link
Contributor

@gmuloc gmuloc commented Jul 5, 2024

Change Summary

f string is missing ..

Related Issue(s)

Fixes issue reported from the field

Component(s) name

plugins

Proposed changes

Making fstring great again

How to test

run with python 3.9 and see the correct message

Checklist

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@gmuloc gmuloc requested review from a team as code owners July 5, 2024 16:00
Copy link

github-actions bot commented Jul 5, 2024

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4183
# Activate the virtual environment
source test-avd-pr-4183/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/gmuloc/avd.git@fix-error-message#subdirectory=python-avd" --force
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/gmuloc/avd.git#/ansible_collections/arista/avd/,fix-error-message --force
# Optional: Install AVD examples
cd test-avd-pr-4183
ansible-playbook arista.avd.install_examples

Copy link
Member

@carlbuchmann carlbuchmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@carlbuchmann carlbuchmann merged commit 775a0de into aristanetworks:devel Jul 9, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants