-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat(eos_designs): Add option for ip igmp snooping fast-leave #4180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4180
# Activate the virtual environment
source test-avd-pr-4180/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/Shivani-gslab/avd.git@fast_leave#subdirectory=python-avd" --force
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/Shivani-gslab/avd.git#/ansible_collections/arista/avd/,fast_leave --force
# Optional: Install AVD examples
cd test-avd-pr-4180
ansible-playbook arista.avd.install_examples |
github-actions
bot
added
state: CI Updated
CI scenario have been updated in the PR
state: Documentation role Updated
role: eos_designs
issue related to eos_designs role
labels
Jul 4, 2024
Vibhu-gslab
approved these changes
Jul 5, 2024
python-avd/pyavd/_eos_designs/structured_config/network_services/ip_igmp_snooping.py
Show resolved
Hide resolved
LGTM! |
laxmikantchintakindi
approved these changes
Jul 9, 2024
...ions/arista/avd/molecule/eos_designs_unit_tests/intended/configs/EVPN-MULTICAST-L3LEAF1B.cfg
Outdated
Show resolved
Hide resolved
laxmikantchintakindi
approved these changes
Jul 9, 2024
gmuloc
added
the
one approval
This PR has one approval and is only missing one more.
label
Jul 9, 2024
gmuloc
requested changes
Jul 9, 2024
python-avd/pyavd/_eos_designs/schema/schema_fragments/defs_network_services.schema.yml
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_designs/schema/schema_fragments/defs_network_services.schema.yml
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_designs/schema/schema_fragments/defs_svi_settings.schema.yml
Outdated
Show resolved
Hide resolved
...ons/arista/avd/molecule/eos_designs_unit_tests/inventory/group_vars/EVPN_MULTICAST_TESTS.yml
Outdated
Show resolved
Hide resolved
...ons/arista/avd/molecule/eos_designs_unit_tests/inventory/group_vars/EVPN_MULTICAST_TESTS.yml
Outdated
Show resolved
Hide resolved
...ons/arista/avd/molecule/eos_designs_unit_tests/inventory/group_vars/EVPN_MULTICAST_TESTS.yml
Show resolved
Hide resolved
...ons/arista/avd/molecule/eos_designs_unit_tests/inventory/group_vars/EVPN_MULTICAST_TESTS.yml
Show resolved
Hide resolved
python-avd/pyavd/_eos_designs/structured_config/network_services/ip_igmp_snooping.py
Show resolved
Hide resolved
gmuloc
reviewed
Jul 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some description schema changed I overlooked in my previous review - last changes and we can merge as far as I am concerned
python-avd/pyavd/_eos_designs/schema/schema_fragments/defs_network_services.schema.yml
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_designs/schema/schema_fragments/defs_network_services.schema.yml
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_designs/schema/schema_fragments/defs_svi_settings.schema.yml
Outdated
Show resolved
Hide resolved
...ons/arista/avd/molecule/eos_designs_unit_tests/inventory/group_vars/EVPN_MULTICAST_TESTS.yml
Show resolved
Hide resolved
Co-authored-by: Guillaume Mulocher <[email protected]>
for more information, see https://pre-commit.ci
gmuloc
approved these changes
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
one approval
This PR has one approval and is only missing one more.
rn: Feat(eos_designs)
role: eos_designs
issue related to eos_designs role
state: CI Updated
CI scenario have been updated in the PR
state: Documentation role Updated
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Add option for ip igmp snooping fast-leave
Related Issue(s)
Fixes #3942
Component(s) name
arista.avd.eos_designs
Proposed changes
Adding
fast_leave
key toevnpn_l2_multicast
and innerigmp_snooping_querier
in tenants (network_services).Inserting
fast_leave
config only ifevpn_l2_multicast.enabled
or innerigmp_snooping_querier.enabled is true
andfast_leave is true
.How to test
Added tests in
eos_designs_unit_tests
molecule scenario in this PR. Test with EOS CLI.Checklist
User Checklist
Repository Checklist