-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat(eos_designs): Add support to add access-groups on l3-interfaces through network-services #4163
Feat(eos_designs): Add support to add access-groups on l3-interfaces through network-services #4163
Conversation
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4163
# Activate the virtual environment
source test-avd-pr-4163/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/laxmikantchintakindi/avd.git@access_groups#subdirectory=python-avd" --force
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/laxmikantchintakindi/avd.git#/ansible_collections/arista/avd/,access_groups --force
# Optional: Install AVD examples
cd test-avd-pr-4163
ansible-playbook arista.avd.install_examples |
python-avd/pyavd/_eos_designs/structured_config/network_services/utils.py
Show resolved
Hide resolved
python-avd/pyavd/_eos_designs/structured_config/network_services/utils.py
Outdated
Show resolved
Hide resolved
93ff5f4
to
476a7ec
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So the PR only partially fix the issue as it is asking for l3_interfaces and SVIs and the PR currently implements only l3_interfaces.
I feel like the code to compute the access_list is a bit of a repeat from the one we have for l3_interfaces under node but maybe there was no easy way to reuse it?
Otherwise it looks good to me if we accept the fact that it is a partial fix.
Can you please remove the comments from the schema?
python-avd/pyavd/_eos_designs/schema/schema_fragments/defs_network_services.schema.yml
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_designs/structured_config/network_services/utils.py
Show resolved
Hide resolved
python-avd/pyavd/_eos_designs/structured_config/network_services/utils.py
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_designs/structured_config/network_services/utils.py
Outdated
Show resolved
Hide resolved
...a/avd/molecule/eos_designs_unit_tests/inventory/group_vars/DC1_TENANTS_NETWORKS/Tenant_A.yml
Outdated
Show resolved
Hide resolved
...lections/arista/avd/molecule/eos_designs_unit_tests/intended/structured_configs/DC1-BL1B.yml
Outdated
Show resolved
Hide resolved
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Conflicts have been resolved. A maintainer will review the pull request shortly. |
63be638
to
0f77a4a
Compare
Many changes since this review.
python-avd/pyavd/_eos_designs/structured_config/network_services/ethernet_interfaces.py
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_designs/structured_config/network_services/utils.py
Outdated
Show resolved
Hide resolved
3fe14ed
to
e0ca9ee
Compare
239f7ca
to
6699db2
Compare
for more information, see https://pre-commit.ci
python-avd/pyavd/_eos_designs/structured_config/network_services/utils.py
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_designs/structured_config/network_services/utils.py
Show resolved
Hide resolved
python-avd/pyavd/_eos_designs/structured_config/network_services/utils.py
Outdated
Show resolved
Hide resolved
…es/utils.py Co-authored-by: Claus Holbech <[email protected]>
…es/utils.py Co-authored-by: Claus Holbech <[email protected]>
…es/utils.py Co-authored-by: Claus Holbech <[email protected]>
for more information, see https://pre-commit.ci
python-avd/pyavd/_eos_designs/schema/schema_fragments/defs_network_services.schema.yml
Show resolved
Hide resolved
python-avd/pyavd/_eos_designs/structured_config/network_services/ip_access_lists.py
Outdated
Show resolved
Hide resolved
…es/ip_access_lists.py Co-authored-by: Guillaume Mulocher <[email protected]>
...a/avd/molecule/eos_designs_unit_tests/inventory/group_vars/DC1_TENANTS_NETWORKS/Tenant_A.yml
Outdated
Show resolved
Hide resolved
Quality Gate passedIssues Measures |
Change Summary
Add support to add access-groups on l3-interfaces through network-services
Related Issue(s)
Fixes #3534
Only address the L3 interfaec but not the SVIs as it was already implemented in #4096.
Component(s) name
arista.avd.eos_designs
Proposed changes
Initial ask
This PR covers the L3 interfaces part in network services - SVIs was done in #4096
How to test
Checklist
User Checklist
Repository Checklist