Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(eos_cli_config_gen): Fix MSDP template typo for sa_filter.out_list #4161

Merged
merged 2 commits into from
Jun 27, 2024

Conversation

gusmb
Copy link
Contributor

@gusmb gusmb commented Jun 26, 2024

Change Summary

Fix MSDP template typo for SA filters

Related Issue(s)

Fixes #4159

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

typo fix in template

How to test

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@gusmb gusmb requested review from a team as code owners June 26, 2024 14:31
Copy link

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4161
# Activate the virtual environment
source test-avd-pr-4161/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/gusmb/ansible-avd.git@issue4159#subdirectory=python-avd" --force
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/gusmb/ansible-avd.git#/ansible_collections/arista/avd/,issue4159 --force
# Optional: Install AVD examples
cd test-avd-pr-4161
ansible-playbook arista.avd.install_examples

@gmuloc gmuloc changed the title Bug(eos_cli_config_gen): Fix MSDP template typo Fix(eos_cli_config_gen): Fix MSDP template typo Jun 26, 2024
@github-actions github-actions bot added the state: CI Updated CI scenario have been updated in the PR label Jun 26, 2024
Copy link
Contributor

@Shivani-gslab Shivani-gslab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@MaheshGSLAB MaheshGSLAB requested a review from a team June 27, 2024 10:30
@ClausHolbechArista ClausHolbechArista changed the title Fix(eos_cli_config_gen): Fix MSDP template typo Fix(eos_cli_config_gen): Fix MSDP template typo for sa_filter.out Jun 27, 2024
@ClausHolbechArista ClausHolbechArista changed the title Fix(eos_cli_config_gen): Fix MSDP template typo for sa_filter.out Fix(eos_cli_config_gen): Fix MSDP template typo for sa_filter.out_list Jun 27, 2024
@ClausHolbechArista ClausHolbechArista merged commit 600383d into aristanetworks:devel Jun 27, 2024
51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rn: Fix(eos_cli_config_gen) state: CI Updated CI scenario have been updated in the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typo in route-msdp.j2 template
5 participants