-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Change the required arguments for eos_cli_config_gen action plugin #4152
Merged
ClausHolbechArista
merged 7 commits into
aristanetworks:devel
from
gmuloc:fix-eos-cli-config-argument-spec
Jun 27, 2024
Merged
Fix: Change the required arguments for eos_cli_config_gen action plugin #4152
ClausHolbechArista
merged 7 commits into
aristanetworks:devel
from
gmuloc:fix-eos-cli-config-argument-spec
Jun 27, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
type: documentation
Improvements or additions to documentation
state: CI Updated
CI scenario have been updated in the PR
labels
Jun 24, 2024
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4152
# Activate the virtual environment
source test-avd-pr-4152/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/gmuloc/avd.git@fix-eos-cli-config-argument-spec#subdirectory=python-avd" --force
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/gmuloc/avd.git#/ansible_collections/arista/avd/,fix-eos-cli-config-argument-spec --force
# Optional: Install AVD examples
cd test-avd-pr-4152
ansible-playbook arista.avd.install_examples |
ClausHolbechArista
changed the title
Fix: Change the required arguments for eos_cli_config_gen
Fix: Change the required arguments for eos_cli_config_gen action plugin
Jun 25, 2024
ClausHolbechArista
approved these changes
Jun 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor comment. I will leave it to you if you wish to import from utils or not.
ansible_collections/arista/avd/plugins/action/eos_cli_config_gen.py
Outdated
Show resolved
Hide resolved
gmuloc
added
the
one approval
This PR has one approval and is only missing one more.
label
Jun 25, 2024
This reverts commit 1768e6e.
MaheshGSLAB
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
one approval
This PR has one approval and is only missing one more.
rn: Fix
state: CI Updated
CI scenario have been updated in the PR
type: documentation
Improvements or additions to documentation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
For people using the arista.avd.eos_cli_config_gen action plugin directly some
Component(s) name
plugins
arista.avd.eos_cli_config_gen
Proposed changes
Leverage
required_if
for config, structured_config and documentation filenamesHow to test
Tested locally using argspec
Checklist
Repository Checklist