Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Change the required arguments for eos_cli_config_gen action plugin #4152

Conversation

gmuloc
Copy link
Contributor

@gmuloc gmuloc commented Jun 24, 2024

Change Summary

For people using the arista.avd.eos_cli_config_gen action plugin directly some

Component(s) name

plugins
arista.avd.eos_cli_config_gen

Proposed changes

Leverage required_if for config, structured_config and documentation filenames

How to test

Tested locally using argspec

Checklist

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@gmuloc gmuloc requested review from a team as code owners June 24, 2024 15:11
@github-actions github-actions bot added type: documentation Improvements or additions to documentation state: CI Updated CI scenario have been updated in the PR labels Jun 24, 2024
Copy link

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4152
# Activate the virtual environment
source test-avd-pr-4152/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/gmuloc/avd.git@fix-eos-cli-config-argument-spec#subdirectory=python-avd" --force
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/gmuloc/avd.git#/ansible_collections/arista/avd/,fix-eos-cli-config-argument-spec --force
# Optional: Install AVD examples
cd test-avd-pr-4152
ansible-playbook arista.avd.install_examples

@ClausHolbechArista ClausHolbechArista changed the title Fix: Change the required arguments for eos_cli_config_gen Fix: Change the required arguments for eos_cli_config_gen action plugin Jun 25, 2024
Copy link
Contributor

@ClausHolbechArista ClausHolbechArista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comment. I will leave it to you if you wish to import from utils or not.

@gmuloc gmuloc added the one approval This PR has one approval and is only missing one more. label Jun 25, 2024
@gmuloc gmuloc requested review from a team June 25, 2024 08:16
@MaheshGSLAB MaheshGSLAB requested a review from a team June 26, 2024 13:13
@ClausHolbechArista ClausHolbechArista merged commit 199710c into aristanetworks:devel Jun 27, 2024
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
one approval This PR has one approval and is only missing one more. rn: Fix state: CI Updated CI scenario have been updated in the PR type: documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants