Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor(eos_designs): Move eos_designs_shared_utils to PyAVD #4126

Conversation

ClausHolbechArista
Copy link
Contributor

@ClausHolbechArista ClausHolbechArista commented Jun 18, 2024

Change Summary

Move internal code in eos_designs_shared_utils to PyAVD

Proposed changes

  • Move files and update all imports
  • Fix issues caught by Pylint

How to test

  • No changes to molecule or pytest. Yay!

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@github-actions github-actions bot added the type: documentation Improvements or additions to documentation label Jun 18, 2024
Copy link

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4126
# Activate the virtual environment
source test-avd-pr-4126/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/ClausHolbechArista/avd.git@refactor/eos_designs/move-eos_designs_shared_utils-to-pyavd#subdirectory=python-avd" --force
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/ClausHolbechArista/avd.git#/ansible_collections/arista/avd/,refactor/eos_designs/move-eos_designs_shared_utils-to-pyavd --force
# Optional: Install AVD examples
cd test-avd-pr-4126
ansible-playbook arista.avd.install_examples

@ClausHolbechArista ClausHolbechArista marked this pull request as ready for review June 18, 2024 12:10
@ClausHolbechArista ClausHolbechArista requested review from a team as code owners June 18, 2024 12:10
Copy link
Member

@carlbuchmann carlbuchmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@carlbuchmann carlbuchmann requested a review from gmuloc June 18, 2024 15:18
Copy link
Contributor

@gmuloc gmuloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once CI passes

@gmuloc gmuloc added the one approval This PR has one approval and is only missing one more. label Jun 18, 2024
@carlbuchmann carlbuchmann merged commit fde40bd into aristanetworks:devel Jun 18, 2024
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
one approval This PR has one approval and is only missing one more. rn: Refactor(eos_designs) type: documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants