Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc: Added the table of WAN validation #4125

Merged
merged 14 commits into from
Jun 21, 2024

Conversation

MaheshGSLAB
Copy link
Contributor

@MaheshGSLAB MaheshGSLAB commented Jun 18, 2024

Change Summary

Added the table of WAN validation.

Component(s) name

AVD Documentation

Proposed changes

Added the table of WAN validation to WAN How-To guide

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

Copy link

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4125
# Activate the virtual environment
source test-avd-pr-4125/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/MaheshGSLAB/ansible-avd.git@WAN-test-doc#subdirectory=python-avd" --force
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/MaheshGSLAB/ansible-avd.git#/ansible_collections/arista/avd/,WAN-test-doc --force
# Optional: Install AVD examples
cd test-avd-pr-4125
ansible-playbook arista.avd.install_examples

@MaheshGSLAB MaheshGSLAB marked this pull request as ready for review June 18, 2024 14:18
@MaheshGSLAB MaheshGSLAB requested review from a team as code owners June 18, 2024 14:18
@gmuloc gmuloc added this to the v4.9.0 milestone Jun 18, 2024
@MaheshGSLAB MaheshGSLAB requested a review from gmuloc June 21, 2024 06:12
Copy link
Contributor

@gmuloc gmuloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks!

@gmuloc gmuloc requested a review from carl-baillargeon June 21, 2024 09:42
@gmuloc gmuloc added the one approval This PR has one approval and is only missing one more. label Jun 21, 2024
Co-authored-by: Carl Baillargeon <[email protected]>
@gmuloc gmuloc merged commit c12e4f7 into aristanetworks:devel Jun 21, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants