Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(eos_validate_state): Add support for ANTA v1.0.0 #4123

Merged
merged 25 commits into from
Jun 20, 2024

Conversation

carl-baillargeon
Copy link
Contributor

@carl-baillargeon carl-baillargeon commented Jun 17, 2024

Change Summary

Add support for ANTA v.1.0.0 and update the documentation.

Component(s) name

arista.avd.eos_validate_state ANTA Mode

Proposed changes

How to test

ansible-playbook playbooks/fabric-validate.yml -e use_anta=true

Checklist

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@carl-baillargeon carl-baillargeon requested review from a team as code owners June 17, 2024 21:26
Copy link

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4123
# Activate the virtual environment
source test-avd-pr-4123/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/carl-baillargeon/avd.git@feat/anta_v1.0.0#subdirectory=python-avd" --force
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/carl-baillargeon/avd.git#/ansible_collections/arista/avd/,feat/anta_v1.0.0 --force
# Optional: Install AVD examples
cd test-avd-pr-4123
ansible-playbook arista.avd.install_examples

@github-actions github-actions bot added the state: CI Updated CI scenario have been updated in the PR label Jun 18, 2024
carlbuchmann and others added 2 commits June 18, 2024 12:41
@gmuloc gmuloc added this to the v4.9.0 milestone Jun 18, 2024
@github-actions github-actions bot removed the state: CI Updated CI scenario have been updated in the PR label Jun 19, 2024
@github-actions github-actions bot added the state: CI Updated CI scenario have been updated in the PR label Jun 19, 2024
@carlbuchmann carlbuchmann requested a review from gmuloc June 19, 2024 15:46
Copy link
Contributor

@philippebureau philippebureau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@carlbuchmann carlbuchmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmuloc gmuloc merged commit e961e9f into aristanetworks:devel Jun 20, 2024
48 checks passed
Copy link
Contributor

@ankudinov ankudinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tested on AVD single DC L3LS example lab.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
EPIC - eos_validate_state ANTA rn: Feat(eos_validate_state) role: eos_designs issue related to eos_designs role role: eos_validate_state state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated type: code quality CI and development toolset type: documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants