Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor(plugins): Move jinja filter code for arista.avd.convert_dicts to PyAVD #4069

Merged
merged 15 commits into from
Jun 10, 2024

Conversation

Vibhu-gslab
Copy link
Contributor

@Vibhu-gslab Vibhu-gslab commented Jun 4, 2024

Change Summary

Move jinja filter code for arista.avd.convert_dicts to PyAVD

Related Issue(s)

Fixes #4072

Component(s) name

Filter

  • convert_dict

Proposed changes

Move convert_dict code to PyAVD.

How to test

CI should catch things.

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

Copy link

github-actions bot commented Jun 4, 2024

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4069
# Activate the virtual environment
source test-avd-pr-4069/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/Vibhu-gslab/avd.git@convert_dict_filter#subdirectory=python-avd" --force
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/Vibhu-gslab/avd.git#/ansible_collections/arista/avd/,convert_dict_filter --force
# Optional: Install AVD examples
cd test-avd-pr-4069
ansible-playbook arista.avd.install_examples

@Vibhu-gslab Vibhu-gslab force-pushed the convert_dict_filter branch 2 times, most recently from 7d43775 to dd4716e Compare June 4, 2024 13:20
@github-actions github-actions bot added the role: eos_designs issue related to eos_designs role label Jun 4, 2024
@Vibhu-gslab Vibhu-gslab force-pushed the convert_dict_filter branch 2 times, most recently from 009574c to dbfc476 Compare June 5, 2024 06:15
@Vibhu-gslab Vibhu-gslab changed the title Refactor(plugins): Move convert_dict filter code to PyAVD Refactor(plugins): Move jinja filter code for arista.avd.convert_dicts to PyAVD Jun 5, 2024
@Vibhu-gslab Vibhu-gslab force-pushed the convert_dict_filter branch 3 times, most recently from 293a06d to 77c415c Compare June 5, 2024 11:28
@github-actions github-actions bot removed the role: eos_designs issue related to eos_designs role label Jun 6, 2024
@Vibhu-gslab Vibhu-gslab force-pushed the convert_dict_filter branch 2 times, most recently from 8d442ed to b4f34a2 Compare June 10, 2024 06:29
@Vibhu-gslab Vibhu-gslab force-pushed the convert_dict_filter branch from b4f34a2 to 18e4c57 Compare June 10, 2024 09:22
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
1 Accepted issue

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@MaheshGSLAB MaheshGSLAB marked this pull request as ready for review June 10, 2024 12:16
@MaheshGSLAB MaheshGSLAB requested review from a team as code owners June 10, 2024 12:16
Copy link
Contributor

@Shivani-gslab Shivani-gslab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@gmuloc gmuloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmuloc gmuloc merged commit 839494e into aristanetworks:devel Jun 10, 2024
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor(plugins): Move jinja filter code for arista.avd.convert_dicts to PyAVD
4 participants