-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor(plugins): Move jinja filter code for arista.avd.convert_dicts to PyAVD #4069
Refactor(plugins): Move jinja filter code for arista.avd.convert_dicts to PyAVD #4069
Conversation
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4069
# Activate the virtual environment
source test-avd-pr-4069/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/Vibhu-gslab/avd.git@convert_dict_filter#subdirectory=python-avd" --force
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/Vibhu-gslab/avd.git#/ansible_collections/arista/avd/,convert_dict_filter --force
# Optional: Install AVD examples
cd test-avd-pr-4069
ansible-playbook arista.avd.install_examples |
7d43775
to
dd4716e
Compare
009574c
to
dbfc476
Compare
293a06d
to
77c415c
Compare
8d442ed
to
b4f34a2
Compare
for more information, see https://pre-commit.ci
Co-authored-by: Guillaume Mulocher <[email protected]>
b4f34a2
to
18e4c57
Compare
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Change Summary
Move jinja filter code for arista.avd.convert_dicts to PyAVD
Related Issue(s)
Fixes #4072
Component(s) name
Filter
convert_dict
Proposed changes
Move
convert_dict
code to PyAVD.How to test
CI should catch things.
Checklist
User Checklist
Repository Checklist