Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(eos_designs): Inband mgmt route-map and prefix-list should not be applied without overlay_routing_protocol #4045

Merged
merged 5 commits into from
May 31, 2024

Conversation

Vibhu-gslab
Copy link
Contributor

@Vibhu-gslab Vibhu-gslab commented May 28, 2024

Change Summary

Related Issue(s)

Fixes #4025

Component(s) name

arista.avd.eos_designs

Proposed changes

Added a check for EVPN VTEPs devices in inband_management.

Checklist

User Checklist

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@Vibhu-gslab Vibhu-gslab self-assigned this May 28, 2024
Copy link

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4045
# Activate the virtual environment
source test-avd-pr-4045/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/Vibhu-gslab/avd.git@route_map_4025#subdirectory=python-avd" --force
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/Vibhu-gslab/avd.git#/ansible_collections/arista/avd/,route_map_4025 --force
# Optional: Install AVD examples
cd test-avd-pr-4045
ansible-playbook arista.avd.install_examples

@github-actions github-actions bot added role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR labels May 28, 2024
@Vibhu-gslab Vibhu-gslab marked this pull request as ready for review May 28, 2024 12:42
@Vibhu-gslab Vibhu-gslab requested review from a team as code owners May 28, 2024 12:42
@Vibhu-gslab Vibhu-gslab changed the title Fix(eos_designs): Route-map and prefix-list should only be applied for EVPN VTEPs. Fix(eos_designs): Inband configuration route-map and prefix-list should not be applied for overlay_routing_protocol. May 28, 2024
@ClausHolbechArista ClausHolbechArista changed the title Fix(eos_designs): Inband configuration route-map and prefix-list should not be applied for overlay_routing_protocol. Fix(eos_designs): Inband mgmt route-map and prefix-list should not be applied without overlay_routing_protocol. May 29, 2024
@ClausHolbechArista ClausHolbechArista changed the title Fix(eos_designs): Inband mgmt route-map and prefix-list should not be applied without overlay_routing_protocol. Fix(eos_designs): Inband mgmt route-map and prefix-list should not be applied without overlay_routing_protocol May 29, 2024
@ClausHolbechArista ClausHolbechArista requested a review from a team May 29, 2024 06:28
@ClausHolbechArista ClausHolbechArista added the one approval This PR has one approval and is only missing one more. label May 29, 2024
@ClausHolbechArista
Copy link
Contributor

@dgonzalez85 can you please test this PR if it addresses the issue you raised? Thanks.

Copy link

@dgonzalez85 dgonzalez85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this branch and looking good, i do not see now the prefix and route-map generated in this design with the inband configuration in L2LS design. Many thanks for the quick fix!!

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@ClausHolbechArista ClausHolbechArista merged commit b15f6d1 into aristanetworks:devel May 31, 2024
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
one approval This PR has one approval and is only missing one more. rn: Fix(eos_designs) role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inband configuration defines a route-map but its not applied
5 participants