-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix(eos_designs): Inband mgmt route-map and prefix-list should not be applied without overlay_routing_protocol #4045
Fix(eos_designs): Inband mgmt route-map and prefix-list should not be applied without overlay_routing_protocol #4045
Conversation
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4045
# Activate the virtual environment
source test-avd-pr-4045/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/Vibhu-gslab/avd.git@route_map_4025#subdirectory=python-avd" --force
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/Vibhu-gslab/avd.git#/ansible_collections/arista/avd/,route_map_4025 --force
# Optional: Install AVD examples
cd test-avd-pr-4045
ansible-playbook arista.avd.install_examples |
dd01d02
to
901e976
Compare
@dgonzalez85 can you please test this PR if it addresses the issue you raised? Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested this branch and looking good, i do not see now the prefix and route-map generated in this design with the inband configuration in L2LS design. Many thanks for the quick fix!!
Quality Gate passedIssues Measures |
Change Summary
Related Issue(s)
Fixes #4025
Component(s) name
arista.avd.eos_designs
Proposed changes
Added a check for EVPN VTEPs devices in inband_management.
Checklist
User Checklist
Repository Checklist