New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(eos_cli_config_gen): Add support for Router BGP missing-policy for address-family all #4034

Merged

ClausHolbechArista merged 16 commits into aristanetworks:devel from MaheshGSLAB:issue-3249

Jun 11, 2024

Contributor

MaheshGSLAB commented May 24, 2024

Change Summary

Add support for Router BGP - Missing policy direction and decision

Related Issue(s)

Fixes #3249

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

Added the support for missing policy on router BGP for neighbor and peer.

How to test

Run molecule

Checklist

User Checklist

N/A

Repository Checklist

My code has been rebased from devel before I start
I have read the CONTRIBUTING document.
My change requires a change to the documentation and documentation have been updated accordingly.
I have updated molecule CI testing accordingly. (check the box if not applicable)

github-actions bot commented May 24, 2024

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4034
# Activate the virtual environment
source test-avd-pr-4034/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/MaheshGSLAB/ansible-avd.git@issue-3249#subdirectory=python-avd" --force
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/MaheshGSLAB/ansible-avd.git#/ansible_collections/arista/avd/,issue-3249 --force
# Optional: Install AVD examples
cd test-avd-pr-4034
ansible-playbook arista.avd.install_examples

github-actions bot assigned MaheshGSLAB

github-actions bot added role: eos_cli_config_gen state: CI Updated state: Documentation role Updated role: eos_designs labels

Shivani-gslab reviewed

View reviewed changes

...llections/arista/avd/roles/eos_cli_config_gen/schemas/schema_fragments/router_bgp.schema.yml Outdated Show resolved Hide resolved

...llections/arista/avd/roles/eos_cli_config_gen/schemas/schema_fragments/router_bgp.schema.yml Outdated Show resolved Hide resolved

...llections/arista/avd/roles/eos_cli_config_gen/schemas/schema_fragments/router_bgp.schema.yml Outdated Show resolved Hide resolved

Vibhu-gslab reviewed

View reviewed changes

ansible_collections/arista/avd/roles/eos_cli_config_gen/templates/eos/router-bgp.j2 Outdated Show resolved Hide resolved

MaheshGSLAB requested review from Shivani-gslab, Vibhu-gslab and ClausHolbechArista

May 30, 2024 09:12

Shivani-gslab reviewed

View reviewed changes

ansible_collections/arista/avd/roles/eos_cli_config_gen/templates/eos/router-bgp.j2 Outdated Show resolved Hide resolved

Shivani-gslab requested changes

View reviewed changes

...llections/arista/avd/roles/eos_cli_config_gen/schemas/schema_fragments/router_bgp.schema.yml Show resolved Hide resolved

ansible_collections/arista/avd/roles/eos_cli_config_gen/templates/eos/router-bgp.j2 Outdated Show resolved Hide resolved

ansible_collections/arista/avd/roles/eos_cli_config_gen/templates/eos/router-bgp.j2 Outdated Show resolved Hide resolved

MaheshGSLAB requested a review from Shivani-gslab

June 3, 2024 10:57

Vibhu-gslab reviewed

View reviewed changes

ansible_collections/arista/avd/roles/eos_cli_config_gen/templates/documentation/router-bgp.j2 Outdated Show resolved Hide resolved

ansible_collections/arista/avd/roles/eos_cli_config_gen/templates/documentation/router-bgp.j2 Outdated Show resolved Hide resolved

...llections/arista/avd/roles/eos_cli_config_gen/schemas/schema_fragments/router_bgp.schema.yml Show resolved Hide resolved

MaheshGSLAB requested a review from Vibhu-gslab

June 3, 2024 13:29

Vibhu-gslab previously approved these changes

View reviewed changes

Vibhu-gslab marked this pull request as ready for review

June 4, 2024 07:03

Vibhu-gslab requested review from a team as code owners

June 4, 2024 07:03

Shivani-gslab previously approved these changes

View reviewed changes

ClausHolbechArista reviewed

View reviewed changes

ansible_collections/arista/avd/roles/eos_cli_config_gen/templates/eos/router-bgp.j2 Outdated Show resolved Hide resolved

ClausHolbechArista requested changes

View reviewed changes

Contributor

ClausHolbechArista left a comment

Please try to work this in with the existing missing_policy data model. Also check how they interoperate on EOS (My guess is they don't so we better combine them in AVD too).
Also IMO the fields in the doc are a bit much for a rarely used feature.

MaheshGSLAB marked this pull request as draft

June 6, 2024 08:35

MaheshGSLAB marked this pull request as ready for review

June 7, 2024 07:26

ClausHolbechArista requested changes

View reviewed changes

...llections/arista/avd/roles/eos_cli_config_gen/schemas/schema_fragments/router_bgp.schema.yml Outdated Show resolved Hide resolved

...llections/arista/avd/roles/eos_cli_config_gen/schemas/schema_fragments/router_bgp.schema.yml Outdated Show resolved Hide resolved

...llections/arista/avd/roles/eos_cli_config_gen/schemas/schema_fragments/router_bgp.schema.yml Outdated Show resolved Hide resolved

...llections/arista/avd/roles/eos_cli_config_gen/schemas/schema_fragments/router_bgp.schema.yml Outdated Show resolved Hide resolved

...llections/arista/avd/roles/eos_cli_config_gen/schemas/schema_fragments/router_bgp.schema.yml Outdated Show resolved Hide resolved

...llections/arista/avd/roles/eos_cli_config_gen/schemas/schema_fragments/router_bgp.schema.yml Outdated Show resolved Hide resolved

...llections/arista/avd/roles/eos_cli_config_gen/schemas/schema_fragments/router_bgp.schema.yml Outdated Show resolved Hide resolved

...llections/arista/avd/roles/eos_cli_config_gen/schemas/schema_fragments/router_bgp.schema.yml Outdated Show resolved Hide resolved

ansible_collections/arista/avd/roles/eos_cli_config_gen/templates/eos/router-bgp.j2 Outdated Show resolved Hide resolved

ansible_collections/arista/avd/roles/eos_cli_config_gen/templates/eos/router-bgp.j2 Outdated Show resolved Hide resolved

ClausHolbechArista dismissed stale reviews from Shivani-gslab and Vibhu-gslab

June 7, 2024 10:00

many changes

ClausHolbechArista requested review from Vibhu-gslab and Shivani-gslab

June 7, 2024 10:00

MaheshGSLAB added 9 commits

June 10, 2024 12:13


          issue-3249: run molecule with latest devel

c263451


          issue-3249: updated with devel

d719f46


          issue-3249: fix the puctuations and keys

0080cb8


          issue-3249: updated the list to str for Missing Policy Out Decision i…

97f46f4

…n peer group


          issue-3249

e0a3cc6


          issue-3249: fix the required key

ef4f61e


          issue-3249: Updated the schema

7528c7b


          issue-3249: updated the j2 logic with new schema

dae3860


          issue-3249: updated the description

e355a31

Vibhu-gslab force-pushed the issue-3249 branch from 62fbeda to e355a31 Compare

June 10, 2024 06:43

ClausHolbechArista requested changes

View reviewed changes

Contributor

ClausHolbechArista left a comment

A few more, but you should be able to just commit from github.

...llections/arista/avd/roles/eos_cli_config_gen/schemas/schema_fragments/router_bgp.schema.yml Outdated Show resolved Hide resolved

...llections/arista/avd/roles/eos_cli_config_gen/schemas/schema_fragments/router_bgp.schema.yml Outdated Show resolved Hide resolved

...llections/arista/avd/roles/eos_cli_config_gen/schemas/schema_fragments/router_bgp.schema.yml Outdated Show resolved Hide resolved

...llections/arista/avd/roles/eos_cli_config_gen/schemas/schema_fragments/router_bgp.schema.yml Outdated Show resolved Hide resolved

...llections/arista/avd/roles/eos_cli_config_gen/schemas/schema_fragments/router_bgp.schema.yml Outdated Show resolved Hide resolved

...llections/arista/avd/roles/eos_cli_config_gen/schemas/schema_fragments/router_bgp.schema.yml Outdated Show resolved Hide resolved

Shivani-gslab reviewed

View reviewed changes

ansible_collections/arista/avd/roles/eos_cli_config_gen/templates/eos/router-bgp.j2 Show resolved Hide resolved


          issue-3249: removed address_family_all key from schema

219db88

ClausHolbechArista approved these changes

View reviewed changes


          Merge branch 'devel' into issue-3249

15cd7d4

ClausHolbechArista added the one approval label


          issue-3249: fix the bool

574a4ea

ClausHolbechArista requested a review from Shivani-gslab

June 10, 2024 12:11


          issue-3249: fix the defined as true for include

ef5fd19

Shivani-gslab requested changes

View reviewed changes

...e_collections/arista/avd/molecule/eos_cli_config_gen/inventory/host_vars/router-bgp-base.yml Show resolved Hide resolved


          issue-3249: added example of all includes

9dac5a5

sonarqubecloud bot commented Jun 10, 2024

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Shivani-gslab approved these changes

View reviewed changes

Vibhu-gslab requested changes

View reviewed changes

Contributor

Vibhu-gslab left a comment

minor suggestions

Vibhu-gslab approved these changes

View reviewed changes

Contributor

Vibhu-gslab left a comment

LGTM!

ClausHolbechArista merged commit c7281d3 into aristanetworks:devel

41 checks passed

github-actions bot added the rn: Feat(eos_cli_config_gen) label

ClausHolbechArista changed the title ~~Feat(eos_cli_config_gen): Add support for Router BGP - Missing policy direction and decision~~ Feat(eos_cli_config_gen): Add support for Router BGP missing-policy for address-family all

github-actions bot added rn: Feat(eos_cli_config_gen) and removed rn: Feat(eos_cli_config_gen) labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

one approval rn: Feat(eos_cli_config_gen) role: eos_cli_config_gen role: eos_designs state: CI Updated state: Documentation role Updated