Feat(eos_cli_config_gen): Add support for 'no bgp redistribute-internal' #4033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4033
# Activate the virtual environment
source test-avd-pr-4033/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/laxmikantchintakindi/avd.git@nobgpredistribute#subdirectory=python-avd" --force
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/laxmikantchintakindi/avd.git#/ansible_collections/arista/avd/,nobgpredistribute --force
# Optional: Install AVD examples
cd test-avd-pr-4033
ansible-playbook arista.avd.install_examples |
github-actions
bot
added
role: eos_cli_config_gen
laxmikantchintakindi
force-pushed
the
nobgpredistribute
branch
from
c215338 to
5eb9908
Compare
github-actions
bot
removed
type: documentation
ansible_collections/arista/avd/roles/eos_cli_config_gen/templates/eos/router-bgp.j2
Show resolved
Hide resolved
...llections/arista/avd/roles/eos_cli_config_gen/schemas/schema_fragments/router_bgp.schema.yml
Show resolved
Hide resolved
ClausHolbechArista
changed the title
ClausHolbechArista
changed the title
ClausHolbechArista
requested changes
May 29, 2024
...llections/arista/avd/roles/eos_cli_config_gen/schemas/schema_fragments/router_bgp.schema.yml
Outdated
Show resolved
Hide resolved
laxmikantchintakindi
force-pushed
the
nobgpredistribute
branch
from
20a3be8 to
c3fd5ff
Compare
MaheshGSLAB
reviewed
May 30, 2024
...llections/arista/avd/roles/eos_cli_config_gen/schemas/schema_fragments/router_bgp.schema.yml
Show resolved
Hide resolved
MaheshGSLAB
approved these changes
May 31, 2024
Vibhu-gslab
force-pushed
the
nobgpredistribute
branch
from
3e7323d to
cb1e59a
Compare
…s/schema_fragments/router_bgp.schema.yml Co-authored-by: Claus Holbech <[email protected]>
Shivani-gslab
force-pushed
the
nobgpredistribute
branch
from
cb1e59a to
6c2af2d
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
The no bgp redistribute-internal command disable route redistribution from the specified domain by removing the corresponding bgp redistribute-internal command from running-config. The default bgp redistribute-internal command enables the redistribution of iBGP routes into an IGP.
Related Issue(s)
Fixes #4012
Component(s) name
arista.avd.eos_cli_config_genProposed changes
Add a key to configure
no bgp redistribute-internalwhich will emit use of eos_cli.How to test
Add a key-value 'redistribute_internal' under router_bgp.bgp.
Checklist
User Checklist
Repository Checklist