Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(eos_cli_config_gen): Add support for dot1x captive portal and supplicant commands #4023

Merged

Conversation

Shivani-gslab
Copy link
Contributor

@Shivani-gslab Shivani-gslab commented May 21, 2024

Change Summary

Add support for dot1x captive portal and supplicant logging.

Related Issue(s)

Fixes #4006

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

Expanding dot1x data-model with captive_portal and supplicant-

dot1x:
     # Web authentication feature authenticates a supplicant through a web page, referred to as a captive portal.
     captive_portal:

       # Supported URL type:
       #   - http: http[s]://<hostname>[:<port>]
       #   - https: http[s]://<hostname>[:<port>]
       url: <str>

       # SSL profile name.
       ssl_profile: <str>

       # Standard access-list name.
       access_list_ipv4: <str>
     supplicant:

       # Dot1x supplicant profiles.
       profiles:
         - name: <str; required; unique>

           # Extensible Authentication Protocol method:
           #   - EAP Flexible Authentication via Secure Tunneling.
           #   - EAP with Transport Layer Security.
           eap_method: <str; "fast" | "tls">

           # User identity.
           identity: <str>
           passphrase_type: <str; "0" | "7" | "8a"; default="7">

           # Extensible Authentication Protocol password.
           passphrase: <str>

           # SSL profile name.
           ssl_profile: <str>

       # Enable supplicant logging.
       logging: <bool>

       # Timeout period in seconds.
       disconnect_cached_results_timeout: <int; 60-65535>

How to test

Molecule test in this PR and test in EOS CLI.

Checklist

PR Checklist

  • Check the command ordering on EOS.

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

Copy link

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4023
# Activate the virtual environment
source test-avd-pr-4023/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/Shivani-gslab/avd.git@dot1x_captive_portal#subdirectory=python-avd" --force
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/Shivani-gslab/avd.git#/ansible_collections/arista/avd/,dot1x_captive_portal --force
# Optional: Install AVD examples
cd test-avd-pr-4023
ansible-playbook arista.avd.install_examples

@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated role: eos_designs issue related to eos_designs role labels May 21, 2024
@Shivani-gslab Shivani-gslab force-pushed the dot1x_captive_portal branch 3 times, most recently from 2c53fcf to 62a100b Compare May 22, 2024 06:43
@Shivani-gslab Shivani-gslab force-pushed the dot1x_captive_portal branch 2 times, most recently from 65f188f to 9cc6e12 Compare May 24, 2024 07:54
@Shivani-gslab Shivani-gslab changed the title Feat(eos_cli_config_gen): Add support for dot1x captive portal and supplicant logging. Feat(eos_cli_config_gen): Add support for dot1x captive portal and supplicant commands. May 24, 2024
@Shivani-gslab Shivani-gslab force-pushed the dot1x_captive_portal branch from 9cc6e12 to fcf1fcf Compare May 24, 2024 09:25
@Vibhu-gslab Vibhu-gslab force-pushed the dot1x_captive_portal branch from fcf1fcf to 325d078 Compare May 24, 2024 09:33
@Shivani-gslab Shivani-gslab force-pushed the dot1x_captive_portal branch from 83395ea to 9f246d5 Compare May 29, 2024 05:04
@Vibhu-gslab Vibhu-gslab changed the title Feat(eos_cli_config_gen): Add support for dot1x captive portal and supplicant commands. Feat(eos_cli_config_gen): Add support for dot1x captive portal and supplicant commands May 29, 2024
@Shivani-gslab Shivani-gslab force-pushed the dot1x_captive_portal branch from f719d05 to 5bd7c4a Compare May 29, 2024 10:23
Copy link
Contributor

@Vibhu-gslab Vibhu-gslab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Vibhu-gslab Vibhu-gslab marked this pull request as ready for review May 29, 2024 11:36
@Vibhu-gslab Vibhu-gslab requested review from a team as code owners May 29, 2024 11:36
@Shivani-gslab Shivani-gslab marked this pull request as draft May 30, 2024 09:46
@Shivani-gslab Shivani-gslab requested a review from MaheshGSLAB May 30, 2024 12:10
@Shivani-gslab Shivani-gslab marked this pull request as ready for review May 30, 2024 12:51
@Shivani-gslab Shivani-gslab marked this pull request as draft May 31, 2024 10:54
@Shivani-gslab Shivani-gslab force-pushed the dot1x_captive_portal branch from 31239da to 8937f06 Compare May 31, 2024 11:43
@Shivani-gslab Shivani-gslab force-pushed the dot1x_captive_portal branch from 8937f06 to 4e49033 Compare May 31, 2024 11:45
@Shivani-gslab Shivani-gslab marked this pull request as ready for review May 31, 2024 12:44
@Shivani-gslab Shivani-gslab marked this pull request as draft June 10, 2024 12:13
@Shivani-gslab Shivani-gslab marked this pull request as ready for review June 10, 2024 12:41
@Shivani-gslab Shivani-gslab force-pushed the dot1x_captive_portal branch from b8c47b1 to ce37cee Compare June 10, 2024 12:44
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@ClausHolbechArista ClausHolbechArista merged commit 3f8645d into aristanetworks:devel Jun 11, 2024
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rn: Feat(eos_cli_config_gen) role: eos_cli_config_gen issue related to eos_cli_config_gen role role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

eos_cli_config_gen: dot1x captive portal and supplicant logging
5 participants