-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat(eos_cli_config_gen): Add support for dot1x captive portal and supplicant commands #4023
Merged
ClausHolbechArista
merged 19 commits into
aristanetworks:devel
from
Shivani-gslab:dot1x_captive_portal
Jun 11, 2024
Merged
Feat(eos_cli_config_gen): Add support for dot1x captive portal and supplicant commands #4023
ClausHolbechArista
merged 19 commits into
aristanetworks:devel
from
Shivani-gslab:dot1x_captive_portal
Jun 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4023
# Activate the virtual environment
source test-avd-pr-4023/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/Shivani-gslab/avd.git@dot1x_captive_portal#subdirectory=python-avd" --force
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/Shivani-gslab/avd.git#/ansible_collections/arista/avd/,dot1x_captive_portal --force
# Optional: Install AVD examples
cd test-avd-pr-4023
ansible-playbook arista.avd.install_examples |
github-actions
bot
added
role: eos_cli_config_gen
issue related to eos_cli_config_gen role
state: CI Updated
CI scenario have been updated in the PR
state: Documentation role Updated
role: eos_designs
issue related to eos_designs role
labels
May 21, 2024
Shivani-gslab
force-pushed
the
dot1x_captive_portal
branch
3 times, most recently
from
May 22, 2024 06:43
2c53fcf
to
62a100b
Compare
Vibhu-gslab
reviewed
May 22, 2024
...le_collections/arista/avd/roles/eos_cli_config_gen/schemas/schema_fragments/dot1x.schema.yml
Show resolved
Hide resolved
ansible_collections/arista/avd/molecule/eos_cli_config_gen/documentation/devices/dot1x.md
Outdated
Show resolved
Hide resolved
...le_collections/arista/avd/roles/eos_cli_config_gen/schemas/schema_fragments/dot1x.schema.yml
Show resolved
Hide resolved
Shivani-gslab
force-pushed
the
dot1x_captive_portal
branch
2 times, most recently
from
May 24, 2024 07:54
65f188f
to
9cc6e12
Compare
Shivani-gslab
changed the title
Feat(eos_cli_config_gen): Add support for dot1x captive portal and supplicant logging.
Feat(eos_cli_config_gen): Add support for dot1x captive portal and supplicant commands.
May 24, 2024
Shivani-gslab
force-pushed
the
dot1x_captive_portal
branch
from
May 24, 2024 09:25
9cc6e12
to
fcf1fcf
Compare
Vibhu-gslab
force-pushed
the
dot1x_captive_portal
branch
from
May 24, 2024 09:33
fcf1fcf
to
325d078
Compare
ansible_collections/arista/avd/roles/eos_cli_config_gen/templates/documentation/dot1x.j2
Outdated
Show resolved
Hide resolved
Shivani-gslab
force-pushed
the
dot1x_captive_portal
branch
from
May 29, 2024 05:04
83395ea
to
9f246d5
Compare
Vibhu-gslab
requested changes
May 29, 2024
ansible_collections/arista/avd/roles/eos_cli_config_gen/templates/documentation/dot1x.j2
Outdated
Show resolved
Hide resolved
Vibhu-gslab
reviewed
May 29, 2024
ansible_collections/arista/avd/molecule/eos_cli_config_gen/intended/configs/dot1x.cfg
Outdated
Show resolved
Hide resolved
Vibhu-gslab
changed the title
Feat(eos_cli_config_gen): Add support for dot1x captive portal and supplicant commands.
Feat(eos_cli_config_gen): Add support for dot1x captive portal and supplicant commands
May 29, 2024
Shivani-gslab
force-pushed
the
dot1x_captive_portal
branch
from
May 29, 2024 10:23
f719d05
to
5bd7c4a
Compare
Vibhu-gslab
approved these changes
May 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
MaheshGSLAB
reviewed
May 29, 2024
ansible_collections/arista/avd/roles/eos_cli_config_gen/docs/tables/dot1x.md
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/roles/eos_cli_config_gen/docs/tables/dot1x.md
Show resolved
Hide resolved
ansible_collections/arista/avd/molecule/eos_cli_config_gen/inventory/host_vars/dot1x.yml
Show resolved
Hide resolved
...le_collections/arista/avd/roles/eos_cli_config_gen/schemas/schema_fragments/dot1x.schema.yml
Outdated
Show resolved
Hide resolved
...le_collections/arista/avd/roles/eos_cli_config_gen/schemas/schema_fragments/dot1x.schema.yml
Outdated
Show resolved
Hide resolved
MaheshGSLAB
reviewed
May 31, 2024
ansible_collections/arista/avd/molecule/eos_cli_config_gen/intended/configs/dot1x.cfg
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/roles/eos_cli_config_gen/docs/tables/dot1x.md
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/roles/eos_cli_config_gen/templates/documentation/dot1x.j2
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/molecule/eos_cli_config_gen/intended/configs/dot1x.cfg
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/roles/eos_cli_config_gen/templates/eos/dot1x.j2
Outdated
Show resolved
Hide resolved
Shivani-gslab
force-pushed
the
dot1x_captive_portal
branch
from
May 31, 2024 11:43
31239da
to
8937f06
Compare
Shivani-gslab
force-pushed
the
dot1x_captive_portal
branch
from
May 31, 2024 11:45
8937f06
to
4e49033
Compare
MaheshGSLAB
reviewed
Jun 3, 2024
ansible_collections/arista/avd/roles/eos_cli_config_gen/templates/documentation/dot1x.j2
Outdated
Show resolved
Hide resolved
Co-authored-by: Mahesh Kumar <[email protected]>
MaheshGSLAB
approved these changes
Jun 5, 2024
ansible_collections/arista/avd/roles/eos_cli_config_gen/templates/eos/dot1x.j2
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/roles/eos_cli_config_gen/templates/documentation/dot1x.j2
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/roles/eos_cli_config_gen/templates/documentation/dot1x.j2
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/roles/eos_cli_config_gen/templates/eos/dot1x.j2
Outdated
Show resolved
Hide resolved
Co-authored-by: Claus Holbech <[email protected]>
ansible_collections/arista/avd/roles/eos_cli_config_gen/docs/tables/dot1x.md
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/roles/eos_cli_config_gen/templates/documentation/dot1x.j2
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/roles/eos_cli_config_gen/templates/documentation/dot1x.j2
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/roles/eos_cli_config_gen/templates/eos/dot1x.j2
Outdated
Show resolved
Hide resolved
Co-authored-by: Claus Holbech <[email protected]>
Shivani-gslab
force-pushed
the
dot1x_captive_portal
branch
from
June 10, 2024 12:44
b8c47b1
to
ce37cee
Compare
ClausHolbechArista
approved these changes
Jun 10, 2024
Quality Gate passedIssues Measures |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
rn: Feat(eos_cli_config_gen)
role: eos_cli_config_gen
issue related to eos_cli_config_gen role
role: eos_designs
issue related to eos_designs role
state: CI Updated
CI scenario have been updated in the PR
state: Documentation role Updated
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Add support for dot1x captive portal and supplicant logging.
Related Issue(s)
Fixes #4006
Component(s) name
arista.avd.eos_cli_config_gen
Proposed changes
Expanding
dot1x
data-model withcaptive_portal
andsupplicant
-How to test
Molecule test in this PR and test in EOS CLI.
Checklist
PR Checklist
Repository Checklist