-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix(cv_deploy): Detect pathfinder metadata studio version and skip unsupported fields #3986
Merged
gmuloc
merged 17 commits into
aristanetworks:devel
from
ClausHolbechArista:fix/cv_deploy/detect-metadata-studio-version
May 24, 2024
Merged
Fix(cv_deploy): Detect pathfinder metadata studio version and skip unsupported fields #3986
gmuloc
merged 17 commits into
aristanetworks:devel
from
ClausHolbechArista:fix/cv_deploy/detect-metadata-studio-version
May 24, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-3986
# Activate the virtual environment
source test-avd-pr-3986/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/ClausHolbechArista/avd.git@fix/cv_deploy/detect-metadata-studio-version#subdirectory=python-avd" --force
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/ClausHolbechArista/avd.git#/ansible_collections/arista/avd/,fix/cv_deploy/detect-metadata-studio-version --force
# Optional: Install AVD examples
cd test-avd-pr-3986
ansible-playbook arista.avd.install_examples |
ClausHolbechArista
force-pushed
the
fix/cv_deploy/detect-metadata-studio-version
branch
from
May 14, 2024 07:15
bd6d4db
to
ed07d60
Compare
...s/arista/avd/plugins/plugin_utils/cv_client/workflows/deploy_cv_pathfinder_metadata_to_cv.py
Outdated
Show resolved
Hide resolved
…workflows/deploy_cv_pathfinder_metadata_to_cv.py
gmuloc
reviewed
May 17, 2024
...s/arista/avd/plugins/plugin_utils/cv_client/workflows/deploy_cv_pathfinder_metadata_to_cv.py
Outdated
Show resolved
Hide resolved
...s/arista/avd/plugins/plugin_utils/cv_client/workflows/deploy_cv_pathfinder_metadata_to_cv.py
Show resolved
Hide resolved
ansible_collections/arista/avd/plugins/plugin_utils/cv_client/client/studio.py
Show resolved
Hide resolved
ayushmittal-arista
requested changes
May 17, 2024
ansible_collections/arista/avd/plugins/plugin_utils/cv_client/client/studio.py
Show resolved
Hide resolved
ansible_collections/arista/avd/plugins/plugin_utils/cv_client/client/studio.py
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/plugins/plugin_utils/cv_client/client/studio.py
Show resolved
Hide resolved
...s/arista/avd/plugins/plugin_utils/cv_client/workflows/deploy_cv_pathfinder_metadata_to_cv.py
Outdated
Show resolved
Hide resolved
...s/arista/avd/plugins/plugin_utils/cv_client/workflows/deploy_cv_pathfinder_metadata_to_cv.py
Show resolved
Hide resolved
...s/arista/avd/plugins/plugin_utils/cv_client/workflows/deploy_cv_pathfinder_metadata_to_cv.py
Outdated
Show resolved
Hide resolved
...s/arista/avd/plugins/plugin_utils/cv_client/workflows/deploy_cv_pathfinder_metadata_to_cv.py
Outdated
Show resolved
Hide resolved
…workflows/deploy_cv_pathfinder_metadata_to_cv.py
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
ayushmittal-arista
approved these changes
May 23, 2024
...s/arista/avd/plugins/plugin_utils/cv_client/workflows/deploy_cv_pathfinder_metadata_to_cv.py
Outdated
Show resolved
Hide resolved
...s/arista/avd/plugins/plugin_utils/cv_client/workflows/deploy_cv_pathfinder_metadata_to_cv.py
Outdated
Show resolved
Hide resolved
…workflows/deploy_cv_pathfinder_metadata_to_cv.py
…x/cv_deploy/detect-metadata-studio-version
Conflicts have been resolved. A maintainer will review the pull request shortly. |
gmuloc
approved these changes
May 24, 2024
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Detect pathfinder metadata studio version and skip unsupported fields
Component(s) name
arista.avd.cv_deploy
How to test
Checklist
User Checklist
Repository Checklist