Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(eos_cli_config_gen): Add support for isis spf-interval hold timer. #3912

Merged

Conversation

Shivani-gslab
Copy link
Contributor

@Shivani-gslab Shivani-gslab commented Apr 26, 2024

Change Summary

Add support for isis spf-interval hold timer and interval_unit.

Related Issue(s)

Fixes #3756

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

Inserting hold_timer and interval_unit in router_isis.spf_interval

router_isis:
    spf_interval:
        interval_unit: <str; "seconds" | "milliseconds"; default="seconds">
        hold_interval: <int; 1-300000> 

How to test

Test with the molecule scenario added in this PR and test the config on EOS CLI.

Checklist

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated role: eos_designs issue related to eos_designs role labels Apr 26, 2024
@Shivani-gslab Shivani-gslab changed the title FEAT(eos_cli_config_gen): Add support for isis spf-interval hold timer. Feat(eos_cli_config_gen): Add support for isis spf-interval hold timer. Apr 26, 2024
@Shivani-gslab Shivani-gslab marked this pull request as ready for review April 26, 2024 13:05
@Shivani-gslab Shivani-gslab requested review from a team as code owners April 26, 2024 13:05
@Shivani-gslab Shivani-gslab marked this pull request as draft April 29, 2024 05:36
@Shivani-gslab Shivani-gslab force-pushed the spf_interval_3756 branch 2 times, most recently from 7808f35 to 14102ac Compare April 29, 2024 10:44
@Shivani-gslab Shivani-gslab marked this pull request as ready for review April 29, 2024 11:00
Copy link
Contributor

@MaheshGSLAB MaheshGSLAB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested on lab

@Shivani-gslab Shivani-gslab marked this pull request as draft May 2, 2024 13:01
@ClausHolbechArista
Copy link
Contributor

ClausHolbechArista commented May 2, 2024

The names of the keys are slightly misleading.
Currently they are <interval> <wait_interval> <hold_interval>
From the help texts given above it seems like they should be <wait_interval> <initial_wait_interval> <hold_interval>. Maybe check show cli commands and the EOS manual to clear this up.

Nevermind. This Pr is only adding the hold_interval, so keep that :)

@Shivani-gslab Shivani-gslab force-pushed the spf_interval_3756 branch 5 times, most recently from 9ed05fc to f8abad9 Compare May 3, 2024 07:21
@Shivani-gslab Shivani-gslab force-pushed the spf_interval_3756 branch 2 times, most recently from 896ced5 to 401e0c3 Compare May 3, 2024 10:10
@Shivani-gslab Shivani-gslab marked this pull request as ready for review May 3, 2024 10:23
@MaheshGSLAB MaheshGSLAB requested a review from a team May 6, 2024 13:41
@MaheshGSLAB MaheshGSLAB requested a review from a team May 6, 2024 13:41
@ClausHolbechArista ClausHolbechArista merged commit 079d45f into aristanetworks:devel May 7, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rn: Feat(eos_cli_config_gen) role: eos_cli_config_gen issue related to eos_cli_config_gen role role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FEAT(eos_cli_config_gen): Add support for isis spf-interval hold timer
4 participants