-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat(eos_cli_config_gen): Option to set RCF for route bgp ipv4/ipv6 mulit-cast and VRF #3821
Merged
ClausHolbechArista
merged 22 commits into
aristanetworks:devel
from
Vibhu-gslab:rcf_vrf_multicast
May 10, 2024
Merged
Feat(eos_cli_config_gen): Option to set RCF for route bgp ipv4/ipv6 mulit-cast and VRF #3821
ClausHolbechArista
merged 22 commits into
aristanetworks:devel
from
Vibhu-gslab:rcf_vrf_multicast
May 10, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
role: eos_cli_config_gen
issue related to eos_cli_config_gen role
label
Apr 8, 2024
github-actions
bot
added
state: CI Updated
CI scenario have been updated in the PR
state: Documentation role Updated
labels
Apr 8, 2024
MaheshGSLAB
reviewed
Apr 15, 2024
ansible_collections/arista/avd/roles/eos_cli_config_gen/docs/tables/router-bgp.md
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/roles/eos_cli_config_gen/docs/tables/router-bgp.md
Show resolved
Hide resolved
Vibhu-gslab
force-pushed
the
rcf_vrf_multicast
branch
from
April 16, 2024 10:28
d7a865a
to
b6501a7
Compare
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Conflicts have been resolved. A maintainer will review the pull request shortly. |
Vibhu-gslab
force-pushed
the
rcf_vrf_multicast
branch
from
April 24, 2024 11:54
d342876
to
b8a8a9c
Compare
MaheshGSLAB
reviewed
Apr 25, 2024
.../avd/molecule/eos_cli_config_gen/documentation/devices/router-bgp-evpn-vpn-import-pruning.md
Show resolved
Hide resolved
MaheshGSLAB
reviewed
Apr 25, 2024
ansible_collections/arista/avd/roles/eos_cli_config_gen/docs/tables/router-bgp.md
Show resolved
Hide resolved
MaheshGSLAB
reviewed
Apr 25, 2024
ansible_collections/arista/avd/roles/eos_cli_config_gen/templates/eos/router-bgp.j2
Outdated
Show resolved
Hide resolved
MaheshGSLAB
reviewed
Apr 25, 2024
ansible_collections/arista/avd/roles/eos_cli_config_gen/templates/eos/router-bgp.j2
Outdated
Show resolved
Hide resolved
Vibhu-gslab
force-pushed
the
rcf_vrf_multicast
branch
from
May 6, 2024 17:41
839120d
to
3eaef91
Compare
MaheshGSLAB
reviewed
May 7, 2024
...ista/avd/molecule/eos_cli_config_gen/intended/configs/router-bgp-evpn-vpn-import-pruning.cfg
Show resolved
Hide resolved
Shivani-gslab
approved these changes
May 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than the ordering @MaheshGSLAB has mentioned, LGTM!
ansible_collections/arista/avd/roles/eos_cli_config_gen/templates/eos/router-bgp.j2
Show resolved
Hide resolved
ClausHolbechArista
approved these changes
May 10, 2024
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
rn: Feat(eos_cli_config_gen)
role: eos_cli_config_gen
issue related to eos_cli_config_gen role
role: eos_designs
issue related to eos_designs role
state: CI Updated
CI scenario have been updated in the PR
state: Documentation role Updated
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Option to set RCF for route bgp ipv4/ipv6 mulit-cast and VRF.
Related Issue(s)
part of #2397
Component(s) name
arista.avd.eos_cli_config_gen
Checklist
Repository Checklist