Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(eos_cli_config_gen): Option to set RCF for route bgp ipv4/ipv6 mulit-cast and VRF #3821

Merged
merged 22 commits into from
May 10, 2024

Conversation

Vibhu-gslab
Copy link
Contributor

Change Summary

Option to set RCF for route bgp ipv4/ipv6 mulit-cast and VRF.

Related Issue(s)

part of #2397

Component(s) name

arista.avd.eos_cli_config_gen

Checklist

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@github-actions github-actions bot added the role: eos_cli_config_gen issue related to eos_cli_config_gen role label Apr 8, 2024
@github-actions github-actions bot added state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated labels Apr 8, 2024
@Vibhu-gslab Vibhu-gslab marked this pull request as ready for review April 16, 2024 10:28
@Vibhu-gslab Vibhu-gslab requested review from a team as code owners April 16, 2024 10:28
@github-actions github-actions bot added the role: eos_designs issue related to eos_designs role label Apr 16, 2024
@Vibhu-gslab Vibhu-gslab marked this pull request as draft April 16, 2024 14:40
@github-actions github-actions bot added the state: conflict PR with conflict label Apr 17, 2024
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Copy link

Conflicts have been resolved. A maintainer will review the pull request shortly.

@github-actions github-actions bot removed the state: conflict PR with conflict label Apr 22, 2024
@Vibhu-gslab Vibhu-gslab marked this pull request as ready for review April 22, 2024 11:52
@Vibhu-gslab Vibhu-gslab requested a review from MaheshGSLAB April 22, 2024 11:52
@Vibhu-gslab Vibhu-gslab marked this pull request as draft April 23, 2024 04:46
@Vibhu-gslab Vibhu-gslab marked this pull request as ready for review April 23, 2024 06:23
@Vibhu-gslab Vibhu-gslab marked this pull request as draft April 23, 2024 07:55
@Vibhu-gslab Vibhu-gslab marked this pull request as draft April 29, 2024 08:58
@Vibhu-gslab Vibhu-gslab force-pushed the rcf_vrf_multicast branch from 839120d to 3eaef91 Compare May 6, 2024 17:41
@Vibhu-gslab Vibhu-gslab requested a review from MaheshGSLAB May 7, 2024 10:37
@Vibhu-gslab Vibhu-gslab marked this pull request as ready for review May 9, 2024 09:10
Copy link
Contributor

@Shivani-gslab Shivani-gslab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the ordering @MaheshGSLAB has mentioned, LGTM!

@Vibhu-gslab Vibhu-gslab marked this pull request as draft May 10, 2024 09:43
@Vibhu-gslab Vibhu-gslab marked this pull request as ready for review May 10, 2024 10:38
@ClausHolbechArista ClausHolbechArista merged commit 0d931f7 into aristanetworks:devel May 10, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rn: Feat(eos_cli_config_gen) role: eos_cli_config_gen issue related to eos_cli_config_gen role role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants