Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(eos_cli_config_gen): Option to set RCF address-family ipv4, ipv6 and evpn #3814

Merged
merged 11 commits into from
May 10, 2024
Merged

Feat(eos_cli_config_gen): Option to set RCF address-family ipv4, ipv6 and evpn #3814

merged 11 commits into from
May 10, 2024

Conversation

Vibhu-gslab
Copy link
Contributor

Change Summary

Adding RCF for router-bgp address-family ipv4, ipv6 and evpn.

Related Issue(s)

part of #2397

Component(s) name

arista.avd.eos_cli_config_gen

Checklist

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@Vibhu-gslab Vibhu-gslab self-assigned this Apr 5, 2024
@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated labels Apr 5, 2024
@Vibhu-gslab Vibhu-gslab force-pushed the rcf_af_ipv4_ipv6_evpn branch from 8b030af to 69f273a Compare April 6, 2024 10:02
MaheshGSLAB
MaheshGSLAB approved these changes Apr 10, 2024
View reviewed changes
Copy link
Contributor

@MaheshGSLAB MaheshGSLAB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, checked IPV4 and EVPN families on lab

@Vibhu-gslab Vibhu-gslab force-pushed the rcf_af_ipv4_ipv6_evpn branch from 520676e to a0588e0 Compare April 16, 2024 10:27
@Vibhu-gslab Vibhu-gslab marked this pull request as ready for review April 16, 2024 10:28
@Vibhu-gslab Vibhu-gslab requested review from a team as code owners April 16, 2024 10:28
@github-actions github-actions bot added the role: eos_designs issue related to eos_designs role label Apr 16, 2024
@Vibhu-gslab Vibhu-gslab force-pushed the rcf_af_ipv4_ipv6_evpn branch from 06d833c to cf8a953 Compare April 17, 2024 12:07
@github-actions github-actions bot added the state: conflict PR with conflict label Apr 17, 2024
@github-actions GitHub Actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions GitHub Actions
Copy link

Conflicts have been resolved. A maintainer will review the pull request shortly.

@github-actions github-actions bot removed the state: conflict PR with conflict label Apr 18, 2024
bjmeuer
bjmeuer approved these changes Apr 20, 2024
View reviewed changes
Copy link
Contributor

@bjmeuer bjmeuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ClausHolbechArista
ClausHolbechArista requested changes Apr 22, 2024
View reviewed changes
Copy link
Contributor

@ClausHolbechArista ClausHolbechArista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change arguments to MyFunction() instead of MyFunction where the () are hardcoded.

@Vibhu-gslab Vibhu-gslab marked this pull request as draft April 23, 2024 01:19
@Vibhu-gslab Vibhu-gslab force-pushed the rcf_af_ipv4_ipv6_evpn branch from 0d878fc to 590af2a Compare April 23, 2024 02:27
@Vibhu-gslab Vibhu-gslab marked this pull request as ready for review April 23, 2024 04:38
@Vibhu-gslab Vibhu-gslab marked this pull request as draft April 23, 2024 07:54
@Vibhu-gslab Vibhu-gslab force-pushed the rcf_af_ipv4_ipv6_evpn branch 2 times, most recently from 288c3d1 to 2202983 Compare April 24, 2024 13:59
@Vibhu-gslab Vibhu-gslab marked this pull request as ready for review April 25, 2024 04:01
@Vibhu-gslab Vibhu-gslab force-pushed the rcf_af_ipv4_ipv6_evpn branch from 2202983 to 9147859 Compare April 25, 2024 04:02
@Vibhu-gslab Vibhu-gslab marked this pull request as ready for review May 2, 2024 05:15
@Vibhu-gslab Vibhu-gslab marked this pull request as draft May 2, 2024 15:19
@Vibhu-gslab Vibhu-gslab force-pushed the rcf_af_ipv4_ipv6_evpn branch from ffa9ffb to 73457da Compare May 6, 2024 13:23
@Vibhu-gslab Vibhu-gslab force-pushed the rcf_af_ipv4_ipv6_evpn branch from 73457da to 7e38622 Compare May 8, 2024 06:11
@Vibhu-gslab Vibhu-gslab requested a review from MaheshGSLAB May 8, 2024 10:14
@MaheshGSLAB MaheshGSLAB marked this pull request as ready for review May 8, 2024 13:35
@ClausHolbechArista ClausHolbechArista dismissed their stale review May 10, 2024 09:35

Changes done

@Vibhu-gslab Vibhu-gslab marked this pull request as draft May 10, 2024 09:43
@Vibhu-gslab Vibhu-gslab marked this pull request as ready for review May 10, 2024 09:46
@ClausHolbechArista ClausHolbechArista merged commit 6c2307b into aristanetworks:devel May 10, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shivani-gslab Shivani-gslab Shivani-gslab approved these changes

@MaheshGSLAB MaheshGSLAB MaheshGSLAB approved these changes

@ClausHolbechArista ClausHolbechArista ClausHolbechArista approved these changes

@bjmeuer bjmeuer bjmeuer approved these changes

Assignees

@Vibhu-gslab Vibhu-gslab

Labels
rn: Feat(eos_cli_config_gen) role: eos_cli_config_gen issue related to eos_cli_config_gen role role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Vibhu-gslab @bjmeuer @ClausHolbechArista @MaheshGSLAB @Shivani-gslab