Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Remove "not RFC1918 IPs" from examples. #3800

Merged
merged 4 commits into from
Apr 4, 2024
Merged

Fix: Remove "not RFC1918 IPs" from examples. #3800

merged 4 commits into from
Apr 4, 2024

Conversation

Shivani-gslab
Copy link
Contributor

@Shivani-gslab Shivani-gslab commented Apr 2, 2024 •
edited
Loading

Change Summary

Remove not RFC1918 IPs from examples.

Related Issue(s)

Fixes #3169

Component(s) name

arista.avd.examples

Checklist

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@Shivani-gslab Shivani-gslab marked this pull request as ready for review April 2, 2024 11:10
@Shivani-gslab Shivani-gslab requested review from a team as code owners April 2, 2024 11:10
gmuloc
gmuloc requested changes Apr 4, 2024
View reviewed changes
Copy link
Contributor

@gmuloc gmuloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR! Put some comments

for each examples the documentation needs to be updated with the new subnets
please also check the inventory.yml file for each to make sure no wrong management IP is left

@Shivani-gslab Shivani-gslab marked this pull request as draft April 4, 2024 08:59
@Shivani-gslab Shivani-gslab marked this pull request as ready for review April 4, 2024 10:39
@Shivani-gslab Shivani-gslab requested a review from gmuloc April 4, 2024 10:39
@Shivani-gslab Shivani-gslab changed the title Fix: Remove not RFC1918 IPs from examples. Fix: Remove "not RFC1918 IPs" from examples. Apr 4, 2024
@Shivani-gslab Shivani-gslab marked this pull request as draft April 4, 2024 10:40
@Shivani-gslab Shivani-gslab marked this pull request as ready for review April 4, 2024 10:53
@Shivani-gslab Shivani-gslab force-pushed the #issue3169_removerfc1918 branch from 1ceb7c8 to 1de8aec Compare April 4, 2024 10:54
gmuloc
gmuloc approved these changes Apr 4, 2024
View reviewed changes
Copy link
Contributor

@gmuloc gmuloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for this and good catch for the basic-configurations ;)

@gmuloc gmuloc added the one approval This PR has one approval and is only missing one more. label Apr 4, 2024
carlbuchmann
carlbuchmann approved these changes Apr 4, 2024
View reviewed changes
Copy link
Member

@carlbuchmann carlbuchmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@carlbuchmann carlbuchmann merged commit 8baacb5 into aristanetworks:devel Apr 4, 2024
37 checks passed
@Shivani-gslab Shivani-gslab deleted the #issue3169_removerfc1918 branch April 16, 2024 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlbuchmann carlbuchmann carlbuchmann approved these changes

@gmuloc gmuloc gmuloc approved these changes

Assignees

@Shivani-gslab Shivani-gslab

Labels
one approval This PR has one approval and is only missing one more. rn: Fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove not RFC1918 IPs from examples
3 participants
@Shivani-gslab @gmuloc @carlbuchmann