-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat(eos_cli_config_gen): Implement managing RCF. #3798
Feat(eos_cli_config_gen): Implement managing RCF. #3798
Conversation
...tions/arista/avd/roles/eos_cli_config_gen/schemas/schema_fragments/router_general.schema.yml
Show resolved
Hide resolved
I think we should update the data-model to add separate keys for operations like |
We cannot commit the function without compilation. So we cannot just give true boolean value to commit and false to compile. May be if it stores the function flash after the compile then we can give true to compile and false on commit. Does this work? |
@laxmikantchintakindi few questions based on quick PR review:
|
...e_collections/arista/avd/molecule/eos_cli_config_gen/documentation/devices/router-general.md
Show resolved
Hide resolved
...e_collections/arista/avd/molecule/eos_cli_config_gen/documentation/devices/router-general.md
Outdated
Show resolved
Hide resolved
@ankudinov I tested this PR with eos_config_deploy_cvp role and RCFs are generated. We have another issue(#2397) opened for of eos_cli_config_gen to apply RCFs to bgp peers. |
ansible_collections/arista/avd/molecule/eos_cli_config_gen/intended/configs/router-general.cfg
Outdated
Show resolved
Hide resolved
...le_collections/arista/avd/molecule/eos_cli_config_gen/inventory/host_vars/router-general.yml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you remove these and say it is basically only for CVP than this needs to be documented that RCF push is only working via CVP.
...tions/arista/avd/roles/eos_cli_config_gen/schemas/schema_fragments/router_general.schema.yml
Outdated
Show resolved
Hide resolved
670ca2b
to
bc8cc3b
Compare
1fce454
to
51fdf9c
Compare
51fdf9c
to
b75a01e
Compare
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Conflicts have been resolved. A maintainer will review the pull request shortly. |
...tions/arista/avd/roles/eos_cli_config_gen/schemas/schema_fragments/router_general.schema.yml
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/roles/eos_cli_config_gen/templates/eos/router-general.j2
Show resolved
Hide resolved
...tions/arista/avd/roles/eos_cli_config_gen/schemas/schema_fragments/router_general.schema.yml
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor code optimization. Please add documentation template for this as well.
ansible_collections/arista/avd/roles/eos_cli_config_gen/templates/eos/router-general.j2
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Change Summary
Route Control Functions getting traction to replace Route-Maps. They should be managable using eos_cli_config_gen.
Related Issue(s)
Fixes #2891
Component(s) name
arista.avd.eos_cli_config_gen
Proposed changes
Added keys for code units.
How to test
Checklist
User Checklist
Repository Checklist