Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(eos_designs): Add support for ipv4_acl_in/out on SVIs defined under network services. #3791

Merged
merged 16 commits into from
May 10, 2024
Merged

Feat(eos_designs): Add support for ipv4_acl_in/out on SVIs defined under network services. #3791

merged 16 commits into from
May 10, 2024

Conversation

Vibhu-gslab
Copy link
Contributor

Change Summary

Add support for applying ip access-lists to SVIs and SVI profiles in eos_designs network services natively.

Related Issue(s)

Fixes #3448

Component(s) name

arista.avd.eos_designs

Checklist

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@Vibhu-gslab Vibhu-gslab self-assigned this Mar 28, 2024
@github-actions github-actions bot added state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated role: eos_designs issue related to eos_designs role labels Mar 28, 2024
ClausHolbechArista
ClausHolbechArista reviewed Apr 2, 2024
View reviewed changes
Copy link
Contributor

@ClausHolbechArista ClausHolbechArista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks much better. Please update the title of the PR to reflect the actual features being added here.

...llections/arista/avd/roles/eos_designs/schemas/schema_fragments/defs_svi_settings.schema.yml Outdated Show resolved Hide resolved
ansible_collections/arista/avd/roles/eos_designs/python_modules/network_services/utils.py Outdated Show resolved Hide resolved
@Vibhu-gslab Vibhu-gslab changed the title Feat(eos_designs): Support access_group_in/out under network services SVI configuration and SVI profiles natively Feat(eos_designs): Add support for applying ip access-lists to SVIs and SVI profiles in eos_designs network services natively. Apr 9, 2024
@Vibhu-gslab Vibhu-gslab force-pushed the ipv4_acl branch 2 times, most recently from a1912ea to 6bd1347 Compare April 15, 2024 07:05
@Vibhu-gslab Vibhu-gslab marked this pull request as ready for review April 15, 2024 10:46
@Vibhu-gslab Vibhu-gslab requested review from a team as code owners April 15, 2024 10:46
@Vibhu-gslab Vibhu-gslab force-pushed the ipv4_acl branch 2 times, most recently from 40e119a to 9ac19d4 Compare April 17, 2024 06:07
@github-actions github-actions bot added the state: conflict PR with conflict label Apr 17, 2024
@github-actions GitHub Actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@ClausHolbechArista
Copy link
Contributor

Moving to draft until conflicts has been resolved. Partially caused by large update to spelling and punctuation, so make sure to watch out for that.

@ClausHolbechArista ClausHolbechArista marked this pull request as draft April 22, 2024 12:07
@github-actions github-actions bot removed the state: conflict PR with conflict label Apr 26, 2024
@github-actions GitHub Actions
Copy link

Conflicts have been resolved. A maintainer will review the pull request shortly.

@Vibhu-gslab Vibhu-gslab marked this pull request as ready for review April 26, 2024 09:17
@ClausHolbechArista ClausHolbechArista changed the title Feat(eos_designs): Add support for applying ip access-lists to SVIs and SVI profiles in eos_designs network services natively. Feat(eos_designs): Add support for ipv4_acl_in/out on SVIs defined under network services. Apr 29, 2024
@Vibhu-gslab Vibhu-gslab marked this pull request as draft April 29, 2024 13:28
@Vibhu-gslab Vibhu-gslab marked this pull request as ready for review April 30, 2024 09:17
@carlbuchmann carlbuchmann self-requested a review May 2, 2024 12:40
MaheshGSLAB
MaheshGSLAB approved these changes May 3, 2024
View reviewed changes
Copy link
Contributor

@MaheshGSLAB MaheshGSLAB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@carlbuchmann carlbuchmann marked this pull request as draft May 3, 2024 19:45
@carlbuchmann carlbuchmann requested a review from MaheshGSLAB May 3, 2024 19:45
@MaheshGSLAB MaheshGSLAB marked this pull request as ready for review May 8, 2024 13:36
@ClausHolbechArista ClausHolbechArista merged commit 84d5609 into aristanetworks:devel May 10, 2024
37 checks passed
@ClausHolbechArista ClausHolbechArista mentioned this pull request Jun 3, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ClausHolbechArista ClausHolbechArista ClausHolbechArista approved these changes

@carlbuchmann carlbuchmann Awaiting requested review from carlbuchmann

@MaheshGSLAB MaheshGSLAB Awaiting requested review from MaheshGSLAB

Assignees

@Vibhu-gslab Vibhu-gslab

Labels
rn: Feat(eos_designs) role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Milestone
No milestone
4 participants
@Vibhu-gslab @ClausHolbechArista @MaheshGSLAB @Shivani-gslab