Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor(deploy_to_cv): Set default values for constraints in metadata studio #3773

Merged
merged 4 commits into from
Mar 27, 2024
Merged

Refactor(deploy_to_cv): Set default values for constraints in metadata studio #3773

merged 4 commits into from
Mar 27, 2024

Conversation

ClausHolbechArista
Copy link
Contributor

Change Summary

Set default values for constraints in metadata studio

Component(s) name

arista.avd.eos_designs

Proposed changes

  • Fix bug for loss_rate vs lossrate.
  • Always set constraints in metadata studio.
    • using default values matching EOS defaults.

How to test

Manual testing.

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@ClausHolbechArista ClausHolbechArista requested review from a team as code owners March 26, 2024 07:08
@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR role: eos_designs issue related to eos_designs role labels Mar 26, 2024
@ClausHolbechArista ClausHolbechArista added this to the v4.7.0 milestone Mar 26, 2024
@carlbuchmann carlbuchmann requested a review from sugetha24 March 26, 2024 17:26
@gmuloc gmuloc added the one approval This PR has one approval and is only missing one more. label Mar 27, 2024
@gmuloc gmuloc merged commit ed452a2 into aristanetworks:devel Mar 27, 2024
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmuloc gmuloc gmuloc approved these changes

@sugetha24 sugetha24 Awaiting requested review from sugetha24

Assignees

@ClausHolbechArista ClausHolbechArista

Labels
EPIC - AVD AutoVPN/WAN one approval This PR has one approval and is only missing one more. rn: Refactor(deploy_to_cv) role: eos_cli_config_gen issue related to eos_cli_config_gen role role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR
Projects
None yet
Milestone
v4.7.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ClausHolbechArista @gmuloc