Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(eos_cli_config_gen): Extend match lists to support IPv4 and IPv6 #3770

Merged
merged 23 commits into from
Mar 26, 2024
Merged

Feat(eos_cli_config_gen): Extend match lists to support IPv4 and IPv6 #3770

merged 23 commits into from
Mar 26, 2024
+230 −5

Conversation

colinmacgiolla
Copy link
Contributor

Change Summary

This PR extends the existings match-lists from just strings to include both IPv4 and IPv6 prefix lists

Related Issue(s)

Fixes #3768

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

The change extends the existing match-list dict to include 2 new keys - prefix_ipv4 and prefix_ipv6.

The data model, as discussed in #3768 is below:

match_list_input:
  prefix_ipv4:
    - name: <str; required; unique>
      prefixes: 
         - <list of IPv4 prefixes>
  prefix_ipv6:
    - name: <str; required; unique>
      prefixes: 
        - <list of IPv6 prefixes>

How to test

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR labels Mar 25, 2024
@colinmacgiolla colinmacgiolla marked this pull request as ready for review March 25, 2024 15:46
@colinmacgiolla colinmacgiolla requested review from a team as code owners March 25, 2024 15:46
ClausHolbechArista
ClausHolbechArista reviewed Mar 25, 2024
View reviewed changes
ansible_collections/arista/avd/molecule/eos_cli_config_gen/documentation/devices/match-lists.md Outdated Show resolved Hide resolved
ansible_collections/arista/avd/roles/eos_cli_config_gen/docs/tables/match-list-input.md Show resolved Hide resolved
...ons/arista/avd/roles/eos_cli_config_gen/schemas/schema_fragments/match_list_input.schema.yml Outdated Show resolved Hide resolved
...ons/arista/avd/roles/eos_cli_config_gen/schemas/schema_fragments/match_list_input.schema.yml Outdated Show resolved Hide resolved
...ons/arista/avd/roles/eos_cli_config_gen/schemas/schema_fragments/match_list_input.schema.yml Outdated Show resolved Hide resolved
...ons/arista/avd/roles/eos_cli_config_gen/schemas/schema_fragments/match_list_input.schema.yml Outdated Show resolved Hide resolved
...ons/arista/avd/roles/eos_cli_config_gen/schemas/schema_fragments/match_list_input.schema.yml Show resolved Hide resolved
colinmacgiolla and others added 2 commits March 26, 2024 09:16
@colinmacgiolla @ClausHolbechArista
Update ansible_collections/arista/avd/roles/eos_cli_config_gen/templa…
e40e2e7 
…tes/documentation/match-list-input.j2

Co-authored-by: Claus Holbech <[email protected]>
@colinmacgiolla @ClausHolbechArista
Update ansible_collections/arista/avd/roles/eos_cli_config_gen/templa…
8100413 
…tes/documentation/match-list-input.j2

Co-authored-by: Claus Holbech <[email protected]>
@Shivani-gslab
Copy link
Contributor

Shivani-gslab commented Mar 26, 2024 •
edited
Loading

Tested the config on EOS CLI, LGTM

@ClausHolbechArista ClausHolbechArista merged commit 2a2c73f into aristanetworks:devel Mar 26, 2024
41 checks passed
@colinmacgiolla colinmacgiolla deleted the extend_match_lists branch March 28, 2024 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shivani-gslab Shivani-gslab Shivani-gslab approved these changes

@ClausHolbechArista ClausHolbechArista ClausHolbechArista approved these changes

Assignees

@colinmacgiolla colinmacgiolla

Labels
rn: Feat(eos_cli_config_gen) role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Extend match-lists to support IP Prefixes
3 participants
@colinmacgiolla @Shivani-gslab @ClausHolbechArista