Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(eos_cli_config_gen): Add aaa unresponsive action under global dot1x #3739

Merged
merged 8 commits into from
Apr 10, 2024

Conversation

Shivani-gslab
Copy link
Contributor

@Shivani-gslab Shivani-gslab commented Mar 14, 2024

Change Summary

Add aaa unresponsive action under global dot1x

Related Issue(s)

Fixes #3376

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

dot1x:
   aaa:
        unresponsive:
          eap_response: <str; "success" | "disabled">
          action:
            apply_cached_results: <bool>
            cached_results_timeout:
              time_duration: <int; >=1>
              time_duration_unit: <str; "days" | "hours" | "minutes" | "seconds"; required>
            traffic_allow: <bool>
            traffic_allow_vlan: <int>
          phone_action:
            apply_cached_results: <bool>
            cached_results_timeout:
              time_duration: <int; >=1>
              time_duration_unit: <str; "days" | "hours" | "minutes" | "seconds"; required>
            traffic_allow: <bool>
          recovery_action_reauthenticate: <bool>

How to test

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated labels Mar 14, 2024
@Shivani-gslab Shivani-gslab marked this pull request as ready for review March 18, 2024 05:32
@Shivani-gslab Shivani-gslab requested review from a team as code owners March 18, 2024 05:32
@Vibhu-gslab Vibhu-gslab marked this pull request as draft March 19, 2024 12:15
@Shivani-gslab Shivani-gslab force-pushed the #issue3376 branch 2 times, most recently from 851d3b7 to 53bc1a7 Compare March 26, 2024 07:39
Copy link
Contributor

@MaheshGSLAB MaheshGSLAB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT, tested on lab

@MaheshGSLAB MaheshGSLAB marked this pull request as ready for review March 27, 2024 11:16
@sugetha24
Copy link
Contributor

phone_action:
        apply_cached_results: false
        traffic_allow: false

will render aaa unresponsive phone action
Similarly,

      action:
        # apply_cached_results: true
        cached_results_timeout:
          time_duration: 10
          time_duration_unit: days

will render aaa unresponsive action

coi202(config-dot1x)#aa unresponsive action 
% Incomplete command

Can we check of all of such instances where you can create incomplete commands?

@sugetha24
Copy link
Contributor

How do I generate this config?

coi202(config-dot1x)#aaa unresponsive phone action apply cached-results else traffic allow ?
  <cr>  

@Shivani-gslab Shivani-gslab marked this pull request as draft April 8, 2024 07:26
@Shivani-gslab
Copy link
Contributor Author

phone_action:
        apply_cached_results: false
        traffic_allow: false

will render aaa unresponsive phone action Similarly,

      action:
        # apply_cached_results: true
        cached_results_timeout:
          time_duration: 10
          time_duration_unit: days

will render aaa unresponsive action

coi202(config-dot1x)#aa unresponsive action 
% Incomplete command

Can we check of all of such instances where you can create incomplete commands?

Thanks for the review @sugetha24.
I have updated the template logic to fix incomplete command generation.

@Shivani-gslab
Copy link
Contributor Author

Shivani-gslab commented Apr 8, 2024

How do I generate this config?

coi202(config-dot1x)#aaa unresponsive phone action apply cached-results else traffic allow ?
  <cr>  

For this we have "apply_alternate" key.
You can find the example test-case here -

I have also added an example in the key description. Thanks!

@Shivani-gslab Shivani-gslab marked this pull request as ready for review April 8, 2024 09:36
@Shivani-gslab Shivani-gslab requested a review from sugetha24 April 8, 2024 09:36
Copy link
Contributor

@sugetha24 sugetha24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ClausHolbechArista ClausHolbechArista merged commit 1624a04 into aristanetworks:devel Apr 10, 2024
40 checks passed
@kmueller68
Copy link
Contributor

kmueller68 commented Apr 10, 2024

@Shivani-gslab and @ClausHolbechArista Arista Thank you very much for implementing this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rn: Feat(eos_cli_config_gen) role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat(eos_cli_config_gen): add aaa unresponsive action under global dot1x
5 participants