Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(eos_designs): Allow custom name for pathfinder Flow tracker tracker and exporter settings #3721

Merged
merged 4 commits into from
Mar 12, 2024
Merged

Feat(eos_designs): Allow custom name for pathfinder Flow tracker tracker and exporter settings #3721

merged 4 commits into from
Mar 12, 2024

Conversation

ayushmittal-arista
Copy link
Contributor

@ayushmittal-arista ayushmittal-arista commented Mar 7, 2024 •
edited
Loading

Change Summary

Currently we generate flow tracking config using predefined names and time values. Add a top level schema to allow overriding those settings.

Related Issue(s)

Fixes #

Component(s) name

arista.avd.eos_designs

Proposed changes

Add a top level key flow_tracking_settings:

flow_tracking_settings: <dict>
    flow_tracker_name : <str, default=WAN-FLOW-TRACKER>
    record_export: <dict>
         on_inactive_timeout: <int, default=70000 (70s)>
         on_interval: <int, default = 300000 (300s) >
   exporter: <dict>
        name: <str, default=DPI-EXPORTER>
        template_interval: <int, default=300000 ( 300s ) >

How to test

molecule

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@ayushmittal-arista ayushmittal-arista requested review from a team as code owners March 7, 2024 19:14
@github-actions github-actions bot added state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated role: eos_designs issue related to eos_designs role labels Mar 7, 2024
@gmuloc
Copy link
Contributor

gmuloc commented Mar 8, 2024

please add the new schema in the PR description

@ayushmittal-arista ayushmittal-arista force-pushed the flowtrack branch 2 times, most recently from d44c2cd to 79dff26 Compare March 11, 2024 11:59
gmuloc
gmuloc approved these changes Mar 12, 2024
View reviewed changes
Copy link
Contributor

@gmuloc gmuloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

...ions/arista/avd/roles/eos_designs/schemas/schema_fragments/flow_tracking_settings.schema.yml Outdated Show resolved Hide resolved
@gmuloc gmuloc added the one approval This PR has one approval and is only missing one more. label Mar 12, 2024
ClausHolbechArista
ClausHolbechArista reviewed Mar 12, 2024
View reviewed changes
...ions/arista/avd/roles/eos_designs/schemas/schema_fragments/flow_tracking_settings.schema.yml Outdated Show resolved Hide resolved
...ions/arista/avd/roles/eos_designs/schemas/schema_fragments/flow_tracking_settings.schema.yml Outdated Show resolved Hide resolved
...ions/arista/avd/roles/eos_designs/schemas/schema_fragments/flow_tracking_settings.schema.yml Outdated Show resolved Hide resolved
...ions/arista/avd/roles/eos_designs/schemas/schema_fragments/flow_tracking_settings.schema.yml Show resolved Hide resolved
...ions/arista/avd/roles/eos_designs/schemas/schema_fragments/flow_tracking_settings.schema.yml Outdated Show resolved Hide resolved
...ions/arista/avd/roles/eos_designs/schemas/schema_fragments/flow_tracking_settings.schema.yml Outdated Show resolved Hide resolved
@gmuloc gmuloc merged commit 5c81dad into aristanetworks:devel Mar 12, 2024
38 checks passed
sugetha24 pushed a commit to sugetha24/ansible-avd that referenced this pull request Mar 12, 2024
@ayushmittal-arista @gmuloc @sugetha24
Feat(eos_designs): Allow custom name for pathfinder Flow tracker trac…
df4acb7 
…ker and exporter settings (aristanetworks#3721)

Co-authored-by: gmuloc <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ClausHolbechArista ClausHolbechArista ClausHolbechArista approved these changes

@gmuloc gmuloc gmuloc approved these changes

Assignees

@ayushmittal-arista ayushmittal-arista

Labels
EPIC - AVD AutoVPN/WAN one approval This PR has one approval and is only missing one more. rn: Feat(eos_designs) role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ayushmittal-arista @gmuloc @ClausHolbechArista