Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(eos_designs): Allow to disable IPsec on dynamic peers for a path-group avd #3695

Merged
merged 3 commits into from
Mar 5, 2024
Merged

Feat(eos_designs): Allow to disable IPsec on dynamic peers for a path-group avd #3695

merged 3 commits into from
Mar 5, 2024

Conversation

ayushmittal-arista
Copy link
Contributor

@ayushmittal-arista ayushmittal-arista commented Mar 4, 2024 •
edited by gmuloc
Loading

Change Summary

A new knob in the schema for path_groups to allow to disable ipsec for dynamic_peers

Related Issue(s)

Fixes #3671

Component(s) name

arista.avd.eos_designs

Proposed changes

A new knob in the schema for path_groups to allow to disable ipsec for dynamic_peers

# Existing model
wan_path_groups:
  - name: <str>
    # Flag to configure IPsec at the path-group level.
    #
    # When set to `true`, IPsec is enabled for both the static and dynamic peers.
    ipsec: <bool; default=True>

Update to

# Existing model
wan_path_groups:
  - name: <str>
    # Path-group IPSec configuration
    ipsec:
        # When set to `true`, IPsec is enabled for dynamic peers.
        dynamic_peers: <bool; default=True>
        # When set to `true`, IPsec is enabled for static peers.
        static_peers: <bool; default=True>

How to test

molecule

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@ayushmittal-arista ayushmittal-arista marked this pull request as ready for review March 4, 2024 17:20
@ayushmittal-arista ayushmittal-arista requested review from a team as code owners March 4, 2024 17:20
@github-actions github-actions bot added state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated role: eos_designs issue related to eos_designs role labels Mar 4, 2024
ClausHolbechArista
ClausHolbechArista reviewed Mar 5, 2024
View reviewed changes
...collections/arista/avd/roles/eos_designs/schemas/schema_fragments/wan_path_groups.schema.yml Outdated Show resolved Hide resolved
...collections/arista/avd/roles/eos_designs/schemas/schema_fragments/wan_path_groups.schema.yml Outdated Show resolved Hide resolved
...collections/arista/avd/roles/eos_designs/schemas/schema_fragments/wan_path_groups.schema.yml Outdated Show resolved Hide resolved
...collections/arista/avd/roles/eos_designs/schemas/schema_fragments/wan_path_groups.schema.yml Outdated Show resolved Hide resolved
...ble_collections/arista/avd/roles/eos_designs/python_modules/overlay/router_path_selection.py Show resolved Hide resolved
...llections/arista/avd/molecule/eos_designs_unit_tests/intended/configs/cv-pathfinder-edge.cfg Show resolved Hide resolved
gmuloc
gmuloc reviewed Mar 5, 2024
View reviewed changes
Copy link
Contributor

@gmuloc gmuloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple of refactoring comments but functionality is what we want

...a/avd/molecule/eos_designs_unit_tests/inventory/host_vars/autovpn-edge-no-default-policy.yml Show resolved Hide resolved
...ble_collections/arista/avd/roles/eos_designs/python_modules/overlay/router_path_selection.py Outdated Show resolved Hide resolved
...ble_collections/arista/avd/roles/eos_designs/python_modules/overlay/router_path_selection.py Outdated Show resolved Hide resolved
...ble_collections/arista/avd/roles/eos_designs/python_modules/overlay/router_path_selection.py Outdated Show resolved Hide resolved
...ble_collections/arista/avd/roles/eos_designs/python_modules/overlay/router_path_selection.py Show resolved Hide resolved
gmuloc
gmuloc approved these changes Mar 5, 2024
View reviewed changes
Copy link
Contributor

@gmuloc gmuloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks!

@gmuloc gmuloc added the one approval This PR has one approval and is only missing one more. label Mar 5, 2024
@gmuloc gmuloc merged commit 2c5e5fc into aristanetworks:devel Mar 5, 2024
54 checks passed
sugetha24 pushed a commit to sugetha24/ansible-avd that referenced this pull request Mar 6, 2024
@ayushmittal-arista @sugetha24
Feat(eos_designs): Allow to disable IPsec on dynamic peers for a path…
712f180 
…-group avd (aristanetworks#3695)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ClausHolbechArista ClausHolbechArista ClausHolbechArista approved these changes

@gmuloc gmuloc gmuloc approved these changes

Assignees

@ayushmittal-arista ayushmittal-arista

Labels
EPIC - AVD AutoVPN/WAN one approval This PR has one approval and is only missing one more. rn: Feat(eos_designs) role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feat(eos_designs): Allow to disable IPsec on dynamic peers for a path-group
3 participants
@ayushmittal-arista @gmuloc @ClausHolbechArista