Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(eos_designs): Add 'dhcp_ip_address' under 'l3_interfaces' node settings #3686

Merged
merged 1 commit into from
Mar 1, 2024

Conversation

gmuloc
Copy link
Contributor

@gmuloc gmuloc commented Feb 29, 2024

Change Summary

Add a key to store the dhcp allocated IPv4/ Mask in scenarii when it is known beforehands.

The key does not do anything now but the goal is to leverage this in ACLs later.

Note that this would fail miserably if the allocated IP address is not static

Component(s) name

arista.avd.eos_designs

Proposed changes

cf summary

How to test

molecule -> no change to config but no error when adding it

Checklist

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@gmuloc gmuloc requested review from a team as code owners February 29, 2024 15:32
@github-actions github-actions bot added state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated role: eos_designs issue related to eos_designs role labels Feb 29, 2024
Copy link
Contributor

@Shivani-gslab Shivani-gslab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked on the basis of PR description. LGTM!

@ClausHolbechArista ClausHolbechArista merged commit d4010cb into aristanetworks:devel Mar 1, 2024
37 checks passed
sugetha24 pushed a commit to sugetha24/ansible-avd that referenced this pull request Mar 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants