Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(eos_cli_config_gen): add hardware flow tracking standard record format support #3681

Merged
merged 10 commits into from
Apr 8, 2024
Merged

Feat(eos_cli_config_gen): add hardware flow tracking standard record format support #3681

merged 10 commits into from
Apr 8, 2024

Conversation

laxmikantchintakindi
Copy link
Contributor

@laxmikantchintakindi laxmikantchintakindi commented Feb 29, 2024 •
edited
Loading

Change Summary

Added support for hardware flow tracking standard record.

Related Issue(s)

Fixes #3650

Component(s) name

`arista.avd.eos_cli_config_gen

Proposed changes

Added a key under flow-tracking:hardware. The value is a boolean.

How to test

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated labels Feb 29, 2024
@laxmikantchintakindi laxmikantchintakindi marked this pull request as ready for review February 29, 2024 07:12
@laxmikantchintakindi laxmikantchintakindi requested review from a team as code owners February 29, 2024 07:12
@ClausHolbechArista ClausHolbechArista changed the title Feat(eos_cli_config_gen): add hardware flow tracking standard record … Feat(eos_cli_config_gen): add hardware flow tracking standard record format support Feb 29, 2024
ClausHolbechArista
ClausHolbechArista previously requested changes Feb 29, 2024
View reviewed changes
Copy link
Contributor

@ClausHolbechArista ClausHolbechArista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the documentation template as well.

@laxmikantchintakindi laxmikantchintakindi marked this pull request as draft February 29, 2024 08:59
@laxmikantchintakindi laxmikantchintakindi marked this pull request as ready for review February 29, 2024 13:06
@Shivani-gslab Shivani-gslab marked this pull request as draft March 1, 2024 05:57
@laxmikantchintakindi laxmikantchintakindi marked this pull request as ready for review March 1, 2024 10:20
Shivani-gslab
Shivani-gslab approved these changes Mar 6, 2024
View reviewed changes
Copy link
Contributor

@Shivani-gslab Shivani-gslab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

MaheshGSLAB
MaheshGSLAB approved these changes Apr 4, 2024
View reviewed changes
Copy link
Contributor

@MaheshGSLAB MaheshGSLAB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, generated config on lab and tested

sugetha24
sugetha24 approved these changes Apr 4, 2024
View reviewed changes
Copy link
Contributor

@sugetha24 sugetha24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Tested: Molecule test and documentation.

@carlbuchmann carlbuchmann dismissed ClausHolbechArista’s stale review April 5, 2024 15:08

documentation template updates

gmuloc
gmuloc approved these changes Apr 5, 2024
View reviewed changes
Copy link
Contributor

@gmuloc gmuloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmuloc gmuloc added the one approval This PR has one approval and is only missing one more. label Apr 5, 2024
@carlbuchmann carlbuchmann merged commit 9ad8172 into aristanetworks:devel Apr 8, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shivani-gslab Shivani-gslab Shivani-gslab approved these changes

@MaheshGSLAB MaheshGSLAB MaheshGSLAB approved these changes

@sugetha24 sugetha24 sugetha24 approved these changes

@gmuloc gmuloc gmuloc approved these changes

@ClausHolbechArista ClausHolbechArista Awaiting requested review from ClausHolbechArista

Assignees

@laxmikantchintakindi laxmikantchintakindi

Labels
one approval This PR has one approval and is only missing one more. rn: Feat(eos_cli_config_gen) role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feat(eos_cli_config_gen): add hardware flow tracking standard record format support
7 participants
@laxmikantchintakindi @gmuloc @sugetha24 @ClausHolbechArista @MaheshGSLAB @Shivani-gslab @carlbuchmann