Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doc: Clean documentation for WAN #3665

Merged
merged 19 commits into from
Mar 28, 2024
Merged

Doc: Clean documentation for WAN #3665

merged 19 commits into from
Mar 28, 2024
+1,212 −940

Conversation

gmuloc
Copy link
Contributor

@gmuloc gmuloc commented Feb 26, 2024 •
edited
Loading

Change Summary

  • Move keys outside of PREVIEW except for HA in schema
  • Move WAN preview input variables to main input variables
  • Move WAN preview how-to to
  • Massage documentation for eos_designs

Component(s) name

arista.avd.eos_designs

Proposed changes

Cf summary

How to test

Nice doc

Checklist

User Checklist

  • Discuss Flow tracking wording as it is rendered only on WAN routers today

Reviwer Checklist

  • eos_designs Input Variables new inputs

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@github-actions github-actions bot added the state: conflict PR with conflict label Mar 25, 2024
@github-actions GitHub Actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@carlbuchmann carlbuchmann added this to the v4.7.0 milestone Mar 26, 2024
@github-actions github-actions bot removed the state: conflict PR with conflict label Mar 26, 2024
@github-actions GitHub Actions
Copy link

Conflicts have been resolved. A maintainer will review the pull request shortly.

@github-actions github-actions bot added the state: conflict PR with conflict label Mar 27, 2024
@github-actions GitHub Actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the state: conflict PR with conflict label Mar 27, 2024
@github-actions GitHub Actions
Copy link

Conflicts have been resolved. A maintainer will review the pull request shortly.

@gmuloc gmuloc changed the title Doc: Start documenting how to build a WAN network with AVD Doc: Clean documentation for WAN Mar 27, 2024
@gmuloc gmuloc marked this pull request as ready for review March 27, 2024 14:24
@gmuloc gmuloc requested review from a team as code owners March 27, 2024 14:24
ClausHolbechArista
ClausHolbechArista reviewed Mar 27, 2024
View reviewed changes
ansible_collections/arista/avd/roles/eos_designs/docs/how-to/wan.md Show resolved Hide resolved
ansible_collections/arista/avd/roles/eos_designs/docs/how-to/wan.md Outdated Show resolved Hide resolved
ansible_collections/arista/avd/roles/eos_designs/docs/how-to/wan.md Outdated Show resolved Hide resolved
ansible_collections/arista/avd/roles/eos_designs/docs/how-to/wan.md Outdated Show resolved Hide resolved
ansible_collections/arista/avd/roles/eos_designs/docs/how-to/wan.md Outdated Show resolved Hide resolved
ansible_collections/arista/avd/roles/eos_designs/docs/how-to/wan.md Outdated Show resolved Hide resolved
ansible_collections/arista/avd/roles/eos_designs/docs/how-to/wan.md Outdated Show resolved Hide resolved
ansible_collections/arista/avd/roles/eos_designs/docs/how-to/wan.md Outdated Show resolved Hide resolved
ansible_collections/arista/avd/roles/eos_designs/docs/how-to/wan.md Outdated Show resolved Hide resolved
ansible_collections/arista/avd/roles/eos_designs/docs/how-to/wan.md Outdated Show resolved Hide resolved
@gmuloc
Copy link
Contributor Author

gmuloc commented Mar 27, 2024

Blocker remove wan_edge and wan_transit

@gmuloc
Copy link
Contributor Author

gmuloc commented Mar 27, 2024

Blocker: ansible different inventories

@github-actions github-actions bot added the type: code quality CI and development toolset label Mar 28, 2024
carlbuchmann
carlbuchmann approved these changes Mar 28, 2024
View reviewed changes
Copy link
Member

@carlbuchmann carlbuchmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmuloc gmuloc merged commit 9e9e2fb into aristanetworks:devel Mar 28, 2024
46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ClausHolbechArista ClausHolbechArista ClausHolbechArista left review comments

@carlbuchmann carlbuchmann carlbuchmann approved these changes

@JulioPDX JulioPDX Awaiting requested review from JulioPDX

Assignees

@gmuloc gmuloc

Labels
EPIC - AVD AutoVPN/WAN rn: Doc role: eos_designs issue related to eos_designs role state: Documentation role Updated type: code quality CI and development toolset
Projects
None yet
Milestone
v4.7.0
Development

Successfully merging this pull request may close these issues.
3 participants
@gmuloc @carlbuchmann @ClausHolbechArista