Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(eos_cli_config_gen): Add more 'pim ipv4' interface commands #3663

Merged
merged 1 commit into from
Mar 1, 2024

Conversation

Shivani-gslab
Copy link
Contributor

@Shivani-gslab Shivani-gslab commented Feb 26, 2024

Change Summary

Add more 'pim ipv4' interface commands.

Related Issue(s)

Fixes #3631

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

<interface>:
      pim:
          ipv4:
            # Set the default for whether Bidirectional Forwarding Detection is enabled for PIM.
            bfd: <bool>
            bidirectional: <bool>
            hello:
              # Number of missed hellos after which the neighbor expires. Range <1.5-65535>.
              count: <str>
              # PIM hello interval in seconds.
              interval: <int; 1-65535>

How to test

Use case example

ethernet_interfaces:
  - name: Ethernet1
    pim:
      ipv4:
        bfd: true
        bidirectional: true
        hello:
           count: 2.5
           interval: 1

should render:

interface Ethernet1
   pim ipv4 bidirectional
   pim ipv4 hello interval 1
   pim ipv4 hello count 2.5
   pim ipv4 bfd

Checklist

User Checklist

  • Verify command ordering from EOS CLI.

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated role: eos_designs issue related to eos_designs role labels Feb 26, 2024
@Shivani-gslab Shivani-gslab marked this pull request as ready for review February 26, 2024 11:31
@Shivani-gslab Shivani-gslab requested review from a team as code owners February 26, 2024 11:31
Copy link
Contributor

@emilarista emilarista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@Vibhu-gslab Vibhu-gslab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gmuloc gmuloc added the one approval This PR has one approval and is only missing one more. label Feb 28, 2024
@ClausHolbechArista ClausHolbechArista merged commit 8593b79 into aristanetworks:devel Mar 1, 2024
67 checks passed
sugetha24 pushed a commit to sugetha24/ansible-avd that referenced this pull request Mar 2, 2024
@Shivani-gslab Shivani-gslab deleted the #issue3631 branch April 16, 2024 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
one approval This PR has one approval and is only missing one more. rn: Feat(eos_cli_config_gen) role: eos_cli_config_gen issue related to eos_cli_config_gen role role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat(eos_cli_config_gen): Add more 'pim ipv4' interface commands
5 participants