Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(eos_designs): L2 inband ztp functionality #3660

Merged
merged 10 commits into from
Mar 21, 2024

Conversation

jrecchia1029
Copy link
Contributor

Change Summary

Adding ability to configure parent devices' l2 links toward downstream ztp devices with appropriate config to allow the downstream device to perform ZTP.

Related Issue(s)

Fixes #3158

Component(s) name

arista.avd.eos_designs

Proposed changes

Configure a device's downstream L2 ethernet interface as an access interface in the downstream device's inband mgmt vlan while keeping that L2 ethernet interface a member of the port-channel to the downstream device but adding lacp fallback mode individual to the port-channel config.

Created an inband_ztp_parent knob

How to test

Updated the INBAND_MGMT_TESTS group in the eos_designs_unit_tests molecule tests

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@jrecchia1029 jrecchia1029 requested review from a team as code owners February 23, 2024 17:01
@github-actions github-actions bot added state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated role: eos_designs issue related to eos_designs role labels Feb 23, 2024
@pvinci-arista
Copy link
Contributor

Should the knob somehow reference that it is l2, or will this same key in the future also apply for l3?

@jrecchia1029
Copy link
Contributor Author

Should the knob somehow reference that it is l2, or will this same key in the future also apply for l3?

I was thinking we could just use the same knob for l3 inband ztp once that is supported. That config will obviously look a lot different though. It will also require that we make the parent device the dhcp server for the downstream device's p2p link.

@carlbuchmann carlbuchmann changed the title Feat(eos_designs): Added l2 inband ztp functionality Feat(eos_designs): L2 inband ztp functionality Feb 23, 2024
@github-actions github-actions bot added the state: conflict PR with conflict label Feb 28, 2024
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the state: conflict PR with conflict label Mar 16, 2024
Copy link

Conflicts have been resolved. A maintainer will review the pull request shortly.

@carlbuchmann carlbuchmann self-requested a review March 21, 2024 16:01
Copy link
Member

@carlbuchmann carlbuchmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@carlbuchmann carlbuchmann added the one approval This PR has one approval and is only missing one more. label Mar 21, 2024
@carlbuchmann carlbuchmann requested a review from a team March 21, 2024 16:02
Copy link
Contributor

@colinmacgiolla colinmacgiolla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@carlbuchmann carlbuchmann merged commit 99ffff9 into aristanetworks:devel Mar 21, 2024
38 checks passed
@jrecchia1029 jrecchia1029 deleted the inband_ztp branch March 22, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
one approval This PR has one approval and is only missing one more. rn: Feat(eos_designs) role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inband ZTP Support in EOS Designs
5 participants