Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(eos_cli_config_gen): Support for EVPN Multihoming IP Mass-withdrawal #3656

Merged
merged 4 commits into from
Feb 26, 2024
Merged

Feat(eos_cli_config_gen): Support for EVPN Multihoming IP Mass-withdrawal #3656

merged 4 commits into from
Feb 26, 2024

Conversation

laxmikantchintakindi
Copy link
Contributor

@laxmikantchintakindi laxmikantchintakindi commented Feb 23, 2024 •
edited
Loading

Change Summary

Support for EVPN Multihoming IP Mass-withdrawal

Related Issue(s)

Fixes #3545

Component(s) name

`arista.avd.eos_cli_config_gen

Proposed changes

Added two inputs for under address-family evpn. Update the template for the new feature.
Added two new keys in address-family evpn/routes in router-bgp schema.

How to test

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated labels Feb 23, 2024
@Shivani-gslab
Copy link
Contributor

Shivani-gslab commented Feb 23, 2024 •
edited
Loading

Please remove the changes inherited from your previous PR. (Create the branch from devel branch)

@laxmikantchintakindi laxmikantchintakindi marked this pull request as ready for review February 23, 2024 15:58
@laxmikantchintakindi laxmikantchintakindi requested review from a team as code owners February 23, 2024 15:58
@ClausHolbechArista ClausHolbechArista requested a review from a team February 26, 2024 11:22
@ClausHolbechArista ClausHolbechArista added the one approval This PR has one approval and is only missing one more. label Feb 26, 2024
MaheshGSLAB
MaheshGSLAB approved these changes Feb 26, 2024
View reviewed changes
Copy link
Contributor

@MaheshGSLAB MaheshGSLAB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmuloc gmuloc merged commit cfb44a2 into aristanetworks:devel Feb 26, 2024
41 checks passed
sugetha24 pushed a commit to sugetha24/ansible-avd that referenced this pull request Feb 28, 2024
@laxmikantchintakindi @ClausHolbechArista @sugetha24
Feat(eos_cli_config_gen): Support for EVPN Multihoming IP Mass-withdr…
f53ee41 
…awal (aristanetworks#3656)

Co-authored-by: Claus Holbech <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaheshGSLAB MaheshGSLAB MaheshGSLAB approved these changes

@ClausHolbechArista ClausHolbechArista ClausHolbechArista approved these changes

@gmuloc gmuloc gmuloc approved these changes

Assignees

@laxmikantchintakindi laxmikantchintakindi

Labels
one approval This PR has one approval and is only missing one more. rn: Feat(eos_cli_config_gen) role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for EVPN Multihoming IP Mass-withdrawal
5 participants
@laxmikantchintakindi @Shivani-gslab @gmuloc @ClausHolbechArista @MaheshGSLAB