Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor(eos_designs): Remove wan_transit and rename wan_edge to wan_router #3654

Merged
merged 10 commits into from
Feb 26, 2024
Merged

Refactor(eos_designs): Remove wan_transit and rename wan_edge to wan_router #3654

merged 10 commits into from
Feb 26, 2024

Conversation

gmuloc
Copy link
Contributor

@gmuloc gmuloc commented Feb 22, 2024 •
edited by ClausHolbechArista
Loading

Change Summary

THIS IS BREAKING but the features are still marked as preview so we can implement this in a minor release.

  • Rename the node type wan_edge to wan_router
  • Remove the node type wan_transit and cv_pathfinder_role from the schema
    Instead use a new key at the node level: 
    node.cv_pathfinder_transit_mode = [zone, region] <default=none>

Component(s) name

arista.avd.eos_designs

Proposed changes

How to test

molecule updated

Checklist

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@gmuloc gmuloc requested review from a team as code owners February 22, 2024 15:29
@github-actions github-actions bot added state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated role: eos_designs issue related to eos_designs role labels Feb 22, 2024
@gmuloc gmuloc marked this pull request as draft February 22, 2024 15:29
@gmuloc gmuloc changed the title Refactor(eos_designs)!: Remove wan_transit Refactor(eos_designs): Remove wan_transit Feb 22, 2024
@github-actions GitHub Actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the state: conflict PR with conflict label Feb 23, 2024
@github-actions GitHub Actions
Copy link

Conflicts have been resolved. A maintainer will review the pull request shortly.

@github-actions github-actions bot removed the state: conflict PR with conflict label Feb 23, 2024
@ClausHolbechArista ClausHolbechArista changed the title Refactor(eos_designs): Remove wan_transit Refactor(eos_designs): Remove wan_transit and rename wan_edge to wan_router Feb 23, 2024
@ClausHolbechArista ClausHolbechArista marked this pull request as ready for review February 23, 2024 11:50
gmuloc
gmuloc commented Feb 23, 2024
View reviewed changes
Copy link
Contributor Author

@gmuloc gmuloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmuloc gmuloc requested review from a team February 23, 2024 13:04
carlbuchmann
carlbuchmann approved these changes Feb 23, 2024
View reviewed changes
Copy link
Member

@carlbuchmann carlbuchmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - tested in POC

@github-actions GitHub Actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the state: conflict PR with conflict label Feb 24, 2024
@github-actions github-actions bot removed the state: conflict PR with conflict label Feb 26, 2024
@github-actions GitHub Actions
Copy link

Conflicts have been resolved. A maintainer will review the pull request shortly.

@ClausHolbechArista ClausHolbechArista merged commit adce17c into aristanetworks:devel Feb 26, 2024
38 checks passed
sugetha24 pushed a commit to sugetha24/ansible-avd that referenced this pull request Feb 28, 2024
@gmuloc @ClausHolbechArista @sugetha24
Refactor(eos_designs): Remove wan_transit and rename wan_edge to wan_…
07a414e 
…router (aristanetworks#3654)

Co-authored-by: Claus Holbech <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ClausHolbechArista ClausHolbechArista ClausHolbechArista approved these changes

@carlbuchmann carlbuchmann carlbuchmann approved these changes

Assignees

@gmuloc gmuloc

Labels
EPIC - AVD AutoVPN/WAN rn: Refactor(eos_designs) role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gmuloc @carlbuchmann @ClausHolbechArista