-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat(eos_designs): Add filter.allow_vrfs and filter.deny_vrfs #3653
Feat(eos_designs): Add filter.allow_vrfs and filter.deny_vrfs #3653
Conversation
..._collections/arista/avd/roles/eos_designs/schemas/schema_fragments/defs_node_type.schema.yml
Outdated
Show resolved
Hide resolved
..._collections/arista/avd/roles/eos_designs/schemas/schema_fragments/defs_node_type.schema.yml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Review descriptions and keys, small suggestion better key name to make it clear.
- reviewed test case
- tested in lab
LGTM
...e_collections/arista/avd/molecule/eos_designs_unit_tests/inventory/host_vars/filter.vrfs.yml
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - just adding one comment to explain the curiosity of the test in details would be good (that is why VRF are in both allow and deny list to really exercise the deny part of the python code)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add comment on test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Change Summary
Add filter.vrfs and filter.not_vrfs
Component(s) name
arista.avd.eos_designs
Proposed changes
How to test
Molecule case with all combinations.
Checklist
User Checklist
Repository Checklist