Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(eos_cli_config_gen): Add support for Postcard telemetry #3642

Merged

Conversation

laxmikantchintakindi
Copy link
Contributor

@laxmikantchintakindi laxmikantchintakindi commented Feb 20, 2024

Change Summary

Add support for Postcard telemetry

Fixes #2848

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

Added schema to enable telemetry postcard policy.
Created a template file and added molecule tests.

How to test

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated labels Feb 20, 2024
@laxmikantchintakindi laxmikantchintakindi marked this pull request as ready for review February 21, 2024 12:40
@laxmikantchintakindi laxmikantchintakindi requested review from a team as code owners February 21, 2024 12:40
@laxmikantchintakindi laxmikantchintakindi marked this pull request as draft March 1, 2024 10:22
…tes/eos/monitor-telemetry-postcard-policy.j2
@Vibhu-gslab Vibhu-gslab marked this pull request as ready for review May 14, 2024 10:03
@laxmikantchintakindi laxmikantchintakindi marked this pull request as draft May 17, 2024 07:42
@laxmikantchintakindi laxmikantchintakindi marked this pull request as ready for review May 17, 2024 08:41
Copy link
Contributor

@Shivani-gslab Shivani-gslab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@laxmikantchintakindi laxmikantchintakindi marked this pull request as draft May 22, 2024 06:24
@laxmikantchintakindi laxmikantchintakindi marked this pull request as ready for review May 22, 2024 13:04
@ClausHolbechArista ClausHolbechArista dismissed Vibhu-gslab’s stale review May 29, 2024 07:25

Requested changes has been implemented

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@ClausHolbechArista ClausHolbechArista merged commit 0e6dea8 into aristanetworks:devel May 29, 2024
41 checks passed
@laxmikantchintakindi laxmikantchintakindi deleted the postcardtelemetry branch May 30, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rn: Feat(eos_cli_config_gen) role: eos_cli_config_gen issue related to eos_cli_config_gen role role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Add support for Postcard telemetry
5 participants