-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat(eos_cli_config_gen): Add support for Postcard telemetry #3642
Merged
ClausHolbechArista
merged 51 commits into
aristanetworks:devel
from
laxmikantchintakindi:postcardtelemetry
May 29, 2024
Merged
Feat(eos_cli_config_gen): Add support for Postcard telemetry #3642
ClausHolbechArista
merged 51 commits into
aristanetworks:devel
from
laxmikantchintakindi:postcardtelemetry
May 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
role: eos_cli_config_gen
issue related to eos_cli_config_gen role
state: CI Updated
CI scenario have been updated in the PR
state: Documentation role Updated
labels
Feb 20, 2024
..._collections/arista/avd/roles/eos_cli_config_gen/templates/eos/monitor-telemetry-postcard.j2
Outdated
Show resolved
Hide resolved
.../avd/roles/eos_cli_config_gen/schemas/schema_fragments/monitor_telemetry_postcard.schema.yml
Outdated
Show resolved
Hide resolved
.../avd/roles/eos_cli_config_gen/schemas/schema_fragments/monitor_telemetry_postcard.schema.yml
Outdated
Show resolved
Hide resolved
.../avd/roles/eos_cli_config_gen/schemas/schema_fragments/monitor_telemetry_postcard.schema.yml
Outdated
Show resolved
Hide resolved
Shivani-gslab
force-pushed
the
postcardtelemetry
branch
from
February 22, 2024 10:37
eb120d3
to
6d5334f
Compare
.../avd/roles/eos_cli_config_gen/schemas/schema_fragments/monitor_telemetry_postcard.schema.yml
Outdated
Show resolved
Hide resolved
.../avd/roles/eos_cli_config_gen/schemas/schema_fragments/monitor_telemetry_postcard.schema.yml
Outdated
Show resolved
Hide resolved
.../avd/roles/eos_cli_config_gen/schemas/schema_fragments/monitor_telemetry_postcard.schema.yml
Outdated
Show resolved
Hide resolved
.../avd/roles/eos_cli_config_gen/schemas/schema_fragments/monitor_telemetry_postcard.schema.yml
Outdated
Show resolved
Hide resolved
.../avd/roles/eos_cli_config_gen/schemas/schema_fragments/monitor_telemetry_postcard.schema.yml
Outdated
Show resolved
Hide resolved
.../avd/roles/eos_cli_config_gen/schemas/schema_fragments/monitor_telemetry_postcard.schema.yml
Outdated
Show resolved
Hide resolved
…tes/eos/monitor-telemetry-postcard-policy.j2
Shivani-gslab
approved these changes
May 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ClausHolbechArista
requested changes
May 21, 2024
...tions/arista/avd/roles/eos_cli_config_gen/templates/eos/monitor-telemetry-postcard-policy.j2
Outdated
Show resolved
Hide resolved
...tions/arista/avd/roles/eos_cli_config_gen/templates/eos/monitor-telemetry-postcard-policy.j2
Outdated
Show resolved
Hide resolved
...tions/arista/avd/roles/eos_cli_config_gen/templates/eos/monitor-telemetry-postcard-policy.j2
Outdated
Show resolved
Hide resolved
ClausHolbechArista
requested changes
May 21, 2024
...ta/avd/roles/eos_cli_config_gen/templates/documentation/monitor-telemetry-postcard-policy.j2
Show resolved
Hide resolved
...ta/avd/roles/eos_cli_config_gen/templates/documentation/monitor-telemetry-postcard-policy.j2
Show resolved
Hide resolved
...les/eos_cli_config_gen/schemas/schema_fragments/monitor_telemetry_postcard_policy.schema.yml
Show resolved
Hide resolved
...tions/arista/avd/roles/eos_cli_config_gen/templates/eos/monitor-telemetry-postcard-policy.j2
Outdated
Show resolved
Hide resolved
...tions/arista/avd/roles/eos_cli_config_gen/templates/eos/monitor-telemetry-postcard-policy.j2
Outdated
Show resolved
Hide resolved
ClausHolbechArista
approved these changes
May 29, 2024
ClausHolbechArista
dismissed
Vibhu-gslab’s stale review
May 29, 2024 07:25
Requested changes has been implemented
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
rn: Feat(eos_cli_config_gen)
role: eos_cli_config_gen
issue related to eos_cli_config_gen role
role: eos_designs
issue related to eos_designs role
state: CI Updated
CI scenario have been updated in the PR
state: Documentation role Updated
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Add support for Postcard telemetry
Fixes #2848
Component(s) name
arista.avd.eos_cli_config_gen
Proposed changes
Added schema to enable telemetry postcard policy.
Created a template file and added molecule tests.
How to test
Checklist
User Checklist
Repository Checklist