-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doc(eos_cli_config_gen, eos_designs): Consistent descriptions for BGP AS schema fields re asdot notation #3618
Conversation
…s re asdot notation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The added description is missing under network service: <network_services_keys.name>.[].vrfs.[].bgp_peers.[].remote_as
.
The scope was only |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, small comment on format
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - much clearer descriptions than before.
… AS schema fields re asdot notation (aristanetworks#3618)
Change Summary
We should not implement convert_types from
float
since it would introduce a risk when the user inputs65000.100
, we would configure65000.1
. We already have that a few places, so to avoid breaking changes, this is kept in this PR.Component(s) name
arista.avd.eos_designs
arista.avd.eos_cli_config_gen