Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(eos_designs): GTSM configuration to limit the TTL permitted for bgp peering to 1 for WAN #3607

Merged
merged 6 commits into from
Feb 19, 2024

Conversation

amitsagar-arsita
Copy link
Contributor

Change Summary

Limit TTL permitted for BGP peering to 1 for WAN

Related Issue(s)

Fixes #3529

Component(s) name

arista.avd.eos_designs

Proposed changes

Generate neighbor WAN_OVERLAY_PEERS ttl maximum-hops 1 for WAN_OVERLAY_PEERS BGP peer group

How to test

Tested using molecule

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@amitsagar-arsita amitsagar-arsita requested review from a team as code owners February 9, 2024 08:05
@github-actions github-actions bot added state: CI Updated CI scenario have been updated in the PR role: eos_designs issue related to eos_designs role labels Feb 9, 2024
@gmuloc gmuloc changed the title Feat(eos_designs):GTSM configuration to limit the TTL permitted for bgp peering to 1 for WAN Feat(eos_designs): GTSM configuration to limit the TTL permitted for bgp peering to 1 for WAN Feb 9, 2024
Copy link
Contributor

@gmuloc gmuloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed this works fine in a lab.
Thanks for picking this up!

2 comments (one to add an option in schema)

Copy link
Contributor

@ClausHolbechArista ClausHolbechArista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@ClausHolbechArista ClausHolbechArista requested a review from a team February 13, 2024 11:40
@ClausHolbechArista ClausHolbechArista added the one approval This PR has one approval and is only missing one more. label Feb 13, 2024
@gmuloc gmuloc merged commit 1496636 into aristanetworks:devel Feb 19, 2024
38 checks passed
sugetha24 pushed a commit to sugetha24/ansible-avd that referenced this pull request Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
EPIC - AVD AutoVPN/WAN one approval This PR has one approval and is only missing one more. rn: Feat(eos_designs) role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat(eos_designs): Use GTSM configuration to limit the TTL permitted for bgp peering to 1 for WAN
3 participants