-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat(eos_designs): GTSM configuration to limit the TTL permitted for bgp peering to 1 for WAN #3607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
state: CI Updated
CI scenario have been updated in the PR
role: eos_designs
issue related to eos_designs role
labels
Feb 9, 2024
gmuloc
changed the title
Feat(eos_designs):GTSM configuration to limit the TTL permitted for bgp peering to 1 for WAN
Feat(eos_designs): GTSM configuration to limit the TTL permitted for bgp peering to 1 for WAN
Feb 9, 2024
gmuloc
reviewed
Feb 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed this works fine in a lab.
Thanks for picking this up!
2 comments (one to add an option in schema)
ansible_collections/arista/avd/roles/eos_designs/python_modules/overlay/router_bgp.py
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/roles/eos_designs/python_modules/overlay/router_bgp.py
Outdated
Show resolved
Hide resolved
4 tasks
ClausHolbechArista
approved these changes
Feb 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks.
ClausHolbechArista
added
the
one approval
This PR has one approval and is only missing one more.
label
Feb 13, 2024
gmuloc
approved these changes
Feb 19, 2024
4 tasks
sugetha24
pushed a commit
to sugetha24/ansible-avd
that referenced
this pull request
Feb 21, 2024
…bgp peering to 1 for WAN (aristanetworks#3607) Co-authored-by: gmuloc <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
EPIC - AVD AutoVPN/WAN
one approval
This PR has one approval and is only missing one more.
rn: Feat(eos_designs)
role: eos_designs
issue related to eos_designs role
state: CI Updated
CI scenario have been updated in the PR
state: Documentation role Updated
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Limit TTL permitted for BGP peering to 1 for WAN
Related Issue(s)
Fixes #3529
Component(s) name
arista.avd.eos_designs
Proposed changes
Generate neighbor WAN_OVERLAY_PEERS ttl maximum-hops 1 for WAN_OVERLAY_PEERS BGP peer group
How to test
Tested using molecule
Checklist
User Checklist
Repository Checklist