Fix(eos_validate_state): ANTA Handle Pydantic + Python 3.9.7 bug gracefully #3601
Conversation
| except TypeError as e: | ||
| # Known bug with Python 3.9.7 and Pydantic `conint`, impacting ANTA. Issue: https://github.com/arista-netdevops-community/anta/issues/557 | ||
| if "Interval() takes no arguments" in str(e): | ||
| msg = "Encountered a known bug with Pydantic and Python 3.9.7. Please consider upgrading Python or using a different environment." |
There was a problem hiding this comment.
Users of AVD do not know anything about ANTA / Pydantic so the message may need to be more explicit
Something like
The ANTA testing framework leveraged in eos_validate_state is using a libary that is unable to load for some python 3.9.x versions (to the best of our knowledge).
Or something better said but we don't have a lot of info :). and probably invite them to a discussion on AVD / ANTA to report their python version where it failed :)
There was a problem hiding this comment.
Updated in 359bec3
| @@ -18,3 +18,26 @@ | |||
| check_mode: false | |||
| when: use_anta | bool | |||
There was a problem hiding this comment.
so stupid question but do we still need the when, now that this can only be included when use_anta is true in the first place? :)
There was a problem hiding this comment.
and yeah I know this is from the one but I am thinking now that it can just be removed and same for the report task :)
There was a problem hiding this comment.
Agreed. Fixed in 359bec3
| if "Interval() takes no arguments" in str(e): | ||
| msg = ( | ||
| "The ANTA testing framework, used in the AVD eos_validate_state role, has encountered a compatibility issue with Python 3.9.x. " | ||
| "Please try a different Python version. For assistance or to report your Python version, please refer to the AVD/ANTA GitHub repositories:\n" |
There was a problem hiding this comment.
let's add a known version where it works (3.9.13 or >=3.10)
There was a problem hiding this comment.
Please if we are going to provide recommendation - something above 3.10. Although it definitely works with latest 3.9
There was a problem hiding this comment.
it is not recommendation really more just a statement that if you are stuck on 3.9 for whatever reason on your system, you are not doomed
There was a problem hiding this comment.
Updated in 44567d6
Change Summary
Added try-except block to catch a known bug with Pydantic
conintand Python 3.9.7, impacting ANTA. The bug manifests when loading Pydantic models usingconint.ANTA related tasks are now grouped in a specific file to avoid loading unnecessary ANTA modules when running validate state in NOT ANTA mode (use_anta=False).
Added a condition in
AnsibleEOSDeviceinit to catch properly when ANTA is not installed or not imported.Related Issue(s)
aristanetworks/anta#557
Component(s) name
arista.avd.eos_validate_stateANTA ModeProposed changes
How to test
Install Python 3.9.7 with ANTA 0.12.0 and run validate state in ANTA mode to see the bug:
Checklist
User Checklist
Repository Checklist