Feat(eos_designs): Set static-routes on node-type l3_interfaces #3599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
state: CI Updated
gmuloc
reviewed
Feb 7, 2024
ansible_collections/arista/avd/roles/eos_designs/docs/tables/wan-interfaces-settings.md
Outdated
Show resolved
Hide resolved
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
gmuloc
added
the
one approval
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
carlbuchmann
reviewed
Feb 8, 2024
...rista/avd/roles/eos_designs/schemas/schema_fragments/defs_node_type_l3_interfaces.schema.yml
Outdated
Show resolved
Hide resolved
carlbuchmann
approved these changes
Feb 8, 2024
MaheshGSLAB
reviewed
Feb 9, 2024
| static_routes.extend( | ||
| {"destination_address_prefix": l3_interface_static_route["prefix"], "gateway": gateway} | ||
| for l3_interface_static_route in l3_interface_static_routes | ||
| ) | ||
|
|
||
| if static_routes: |
There was a problem hiding this comment.
return static_routes if static_routes else None
There was a problem hiding this comment.
Even better to just return static_routes or None, but we have this pattern everywhere and we will fix it throughout at some point.
…a_fragments/defs_node_type_l3_interfaces.schema.yml Co-authored-by: Carl Buchmann <[email protected]>
MaheshGSLAB
approved these changes
Feb 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Set static-routes on node-type l3_interfaces
Component(s) name
arista.avd.eos_designsProposed changes
set_default_routetodhcp_accept_default_routestatic_routes: <list[str]>How to test
Updated existing molecule tests with no config changes.
Checklist
User Checklist
Repository Checklist