Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(eos_cli_config_gen): Add support for MPLS resolution RIBs #3592

Conversation

chetryan
Copy link
Contributor

@chetryan chetryan commented Feb 5, 2024

Change Summary

Add support for the next-hop mpls resolution ribs command.

Since the command supports both a Primary-RIB and a Fallback-RIB and both can be quite complex, I propose that we support string input for now.

Related Issue(s)

Fixes #3415

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

  • Updates the data model for eos_cli_config_gen
  • Update the jinja templates for the documentation and eos config generation

How to test

  • molecule test -s eos_cli_config_gen

Checklist

User Checklist

  • Review the change to the date modle
  • Review the change to generated config and documentation

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@chetryan chetryan self-assigned this Feb 5, 2024
@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated role: eos_designs issue related to eos_designs role labels Feb 5, 2024
@chetryan chetryan marked this pull request as ready for review February 5, 2024 14:14
@chetryan chetryan requested review from a team as code owners February 5, 2024 14:14
@chetryan chetryan marked this pull request as draft February 5, 2024 14:19
@chetryan chetryan marked this pull request as ready for review February 5, 2024 15:59
@github-actions github-actions bot added the state: conflict PR with conflict label Feb 6, 2024
Copy link

github-actions bot commented Feb 6, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@chetryan chetryan force-pushed the 3415-feateos_cli_config_gen-evpn-address-family-support-for-tunnel-rib branch from 643696f to ea1e8de Compare February 7, 2024 19:52
@github-actions github-actions bot removed the state: conflict PR with conflict label Feb 7, 2024
Copy link

github-actions bot commented Feb 7, 2024

Conflicts have been resolved. A maintainer will review the pull request shortly.

@chetryan chetryan force-pushed the 3415-feateos_cli_config_gen-evpn-address-family-support-for-tunnel-rib branch from ca3b674 to 4166cfc Compare February 8, 2024 11:27
@chetryan chetryan force-pushed the 3415-feateos_cli_config_gen-evpn-address-family-support-for-tunnel-rib branch from 4166cfc to e1ad879 Compare February 8, 2024 11:49
@github-actions github-actions bot added the state: conflict PR with conflict label Feb 8, 2024
Copy link

github-actions bot commented Feb 8, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the state: conflict PR with conflict label Feb 9, 2024
Copy link

github-actions bot commented Feb 9, 2024

Conflicts have been resolved. A maintainer will review the pull request shortly.

@ClausHolbechArista
Copy link
Contributor

ClausHolbechArista commented Feb 12, 2024

Please rebase and delete the .pickle files when it asks. We have removed those from the repo.

@github-actions github-actions bot removed the role: eos_designs issue related to eos_designs role label Feb 13, 2024
Copy link
Contributor

@ClausHolbechArista ClausHolbechArista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ClausHolbechArista ClausHolbechArista added the one approval This PR has one approval and is only missing one more. label Feb 13, 2024
@ClausHolbechArista ClausHolbechArista requested a review from a team February 13, 2024 10:05
@ClausHolbechArista ClausHolbechArista changed the title Feat(eos_cli_config_gen): Add support for mpls resolution ribs Feat(eos_cli_config_gen): Add support for MPLS resolution RIBs Feb 13, 2024
Copy link
Contributor

@tgodaA tgodaA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ClausHolbechArista ClausHolbechArista merged commit b68c077 into aristanetworks:devel Feb 14, 2024
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
one approval This PR has one approval and is only missing one more. rn: Feat(eos_cli_config_gen) role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Feat(eos_cli_config_gen): EVPN Address family support for tunnel-rib
3 participants