Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor(eos_designs): Use a specific peer group for WAN-RR #3591

Merged
merged 2 commits into from
Feb 7, 2024
Merged

Refactor(eos_designs): Use a specific peer group for WAN-RR #3591

merged 2 commits into from
Feb 7, 2024

Conversation

gmuloc
Copy link
Contributor

@gmuloc gmuloc commented Feb 5, 2024 •
edited by carlbuchmann
Loading

Change Summary

the WAN-RR were made to use the RR-OVERLAY-PEERS peer-group for BGP but this leads to potential issue if trying to configur MPLS route servers capabilities on a WAN-RR as the two BGP peering configuration would be conflicting (TTL 1 for WAN #3587 and BFD #3586).

Component(s) name

arista.avd.eos_designs

Proposed changes

Create a special key wan_rr_overlay_peers

How to test

molecule

Checklist

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@gmuloc gmuloc requested review from a team as code owners February 5, 2024 14:11
@github-actions github-actions bot added state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated role: eos_designs issue related to eos_designs role labels Feb 5, 2024
@github-actions github-actions bot added the state: conflict PR with conflict label Feb 5, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 5, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@ClausHolbechArista ClausHolbechArista requested a review from a team February 6, 2024 06:41
@ClausHolbechArista ClausHolbechArista added the one approval This PR has one approval and is only missing one more. label Feb 6, 2024
@ClausHolbechArista ClausHolbechArista mentioned this pull request Feb 6, 2024
Merged
4 tasks
@github-actions github-actions bot removed the state: conflict PR with conflict label Feb 6, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 6, 2024

Conflicts have been resolved. A maintainer will review the pull request shortly.

carlbuchmann
carlbuchmann approved these changes Feb 7, 2024
View reviewed changes
Copy link
Member

@carlbuchmann carlbuchmann left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM tested in lab

@carlbuchmann carlbuchmann merged commit 02f7d85 into aristanetworks:devel Feb 7, 2024
42 checks passed
@ClausHolbechArista ClausHolbechArista mentioned this pull request Feb 7, 2024
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ClausHolbechArista ClausHolbechArista ClausHolbechArista approved these changes

@carlbuchmann carlbuchmann carlbuchmann approved these changes

Assignees

@gmuloc gmuloc

Labels
EPIC - AVD AutoVPN/WAN one approval This PR has one approval and is only missing one more. rn: Refactor(eos_designs) role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gmuloc @carlbuchmann @ClausHolbechArista