Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(eos_cli_config_gen): Add set_overload_bit and authentication to router_isis #3578

Merged
merged 9 commits into from
Feb 16, 2024
Merged

Feat(eos_cli_config_gen): Add set_overload_bit and authentication to router_isis #3578

merged 9 commits into from
Feb 16, 2024

Conversation

Shivani-gslab
Copy link
Contributor

@Shivani-gslab Shivani-gslab commented Feb 1, 2024 •
edited
Loading

Change Summary

Add set_overload_bit and authentication to router_isis

Related Issue(s)

Fixes #3247

Component(s) name

arista.avd.eos_cli_config_gen

Checklist

User Checklist

  • Verify command ordering on EOS

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@Shivani-gslab Shivani-gslab requested review from a team as code owners February 1, 2024 13:24
@Shivani-gslab Shivani-gslab marked this pull request as draft February 1, 2024 13:24
@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated role: eos_designs issue related to eos_designs role state: conflict PR with conflict labels Feb 1, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 2, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the state: conflict PR with conflict label Feb 2, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 2, 2024

Conflicts have been resolved. A maintainer will review the pull request shortly.

@Shivani-gslab Shivani-gslab marked this pull request as ready for review February 2, 2024 10:25
@github-actions github-actions bot added the state: conflict PR with conflict label Feb 3, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 3, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the state: conflict PR with conflict label Feb 6, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 6, 2024

Conflicts have been resolved. A maintainer will review the pull request shortly.

ClausHolbechArista
ClausHolbechArista reviewed Feb 6, 2024
View reviewed changes
...lections/arista/avd/roles/eos_cli_config_gen/schemas/schema_fragments/router_isis.schema.yml Outdated Show resolved Hide resolved
...lections/arista/avd/roles/eos_cli_config_gen/schemas/schema_fragments/router_isis.schema.yml Show resolved Hide resolved
...lections/arista/avd/roles/eos_cli_config_gen/schemas/schema_fragments/router_isis.schema.yml Show resolved Hide resolved
...lections/arista/avd/roles/eos_cli_config_gen/schemas/schema_fragments/router_isis.schema.yml Show resolved Hide resolved
...lections/arista/avd/roles/eos_cli_config_gen/schemas/schema_fragments/router_isis.schema.yml Outdated Show resolved Hide resolved
...lections/arista/avd/roles/eos_cli_config_gen/schemas/schema_fragments/router_isis.schema.yml Outdated Show resolved Hide resolved
...lections/arista/avd/roles/eos_cli_config_gen/schemas/schema_fragments/router_isis.schema.yml Outdated Show resolved Hide resolved
...lections/arista/avd/roles/eos_cli_config_gen/schemas/schema_fragments/router_isis.schema.yml Outdated Show resolved Hide resolved
...lections/arista/avd/roles/eos_cli_config_gen/schemas/schema_fragments/router_isis.schema.yml Show resolved Hide resolved
...lections/arista/avd/roles/eos_cli_config_gen/schemas/schema_fragments/router_isis.schema.yml Outdated Show resolved Hide resolved
@Shivani-gslab Shivani-gslab marked this pull request as draft February 6, 2024 11:14
@github-actions github-actions bot added the state: conflict PR with conflict label Feb 6, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 6, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the state: conflict PR with conflict label Feb 6, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 6, 2024

Conflicts have been resolved. A maintainer will review the pull request shortly.

@Shivani-gslab Shivani-gslab marked this pull request as ready for review February 6, 2024 13:19
@Shivani-gslab Shivani-gslab marked this pull request as draft February 8, 2024 06:39
@Shivani-gslab Shivani-gslab marked this pull request as ready for review February 8, 2024 14:32
@github-actions github-actions bot added the state: conflict PR with conflict label Feb 8, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 8, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 9, 2024

Conflicts have been resolved. A maintainer will review the pull request shortly.

@github-actions github-actions bot removed the state: conflict PR with conflict label Feb 9, 2024
@Shivani-gslab Shivani-gslab marked this pull request as draft February 14, 2024 06:40
@github-actions github-actions bot removed the role: eos_designs issue related to eos_designs role label Feb 14, 2024
@Shivani-gslab Shivani-gslab marked this pull request as ready for review February 14, 2024 07:35
@ClausHolbechArista ClausHolbechArista requested a review from a team February 16, 2024 06:37
@ClausHolbechArista ClausHolbechArista added the one approval This PR has one approval and is only missing one more. label Feb 16, 2024
emilarista
emilarista approved these changes Feb 16, 2024
View reviewed changes
Copy link
Contributor

@emilarista emilarista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

...e_collections/arista/avd/molecule/eos_cli_config_gen/inventory/host_vars/router-isis-new.yml Show resolved Hide resolved
@ClausHolbechArista ClausHolbechArista merged commit 73108c0 into aristanetworks:devel Feb 16, 2024
41 checks passed
sugetha24 pushed a commit to sugetha24/ansible-avd that referenced this pull request Feb 21, 2024
@Shivani-gslab @sugetha24
Feat(eos_cli_config_gen): Add set_overload_bit and authentication to …
983f83e 
…router_isis (aristanetworks#3578)
@Shivani-gslab Shivani-gslab deleted the #issue3247 branch October 7, 2024 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilarista emilarista emilarista approved these changes

@ClausHolbechArista ClausHolbechArista ClausHolbechArista approved these changes

Assignees

@Shivani-gslab Shivani-gslab

Labels
one approval This PR has one approval and is only missing one more. rn: Feat(eos_cli_config_gen) role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

router isis - Missing Features
3 participants
@Shivani-gslab @ClausHolbechArista @emilarista