Feat(eos_designs): Inject default VRF policy with a match-all statement when missing #3560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
state: CI Updated
...ollections/arista/avd/molecule/eos_designs_unit_tests/inventory/group_vars/AUTOVPN_TESTS.yml
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/molecule/eos_designs_unit_tests/intended/configs/autovpn-rr1.cfg
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/roles/eos_designs/python_modules/network_services/utils.py
Show resolved
Hide resolved
ansible_collections/arista/avd/roles/eos_designs/python_modules/network_services/utils.py
Outdated
Show resolved
Hide resolved
gmuloc
commented
Jan 30, 2024
ansible_collections/arista/avd/roles/eos_designs/python_modules/network_services/utils.py
Show resolved
Hide resolved
gmuloc
commented
Jan 30, 2024
ansible_collections/arista/avd/roles/eos_designs/python_modules/network_services/utils.py
Outdated
Show resolved
Hide resolved
ClausHolbechArista
approved these changes
Jan 30, 2024
ansible_collections/arista/avd/roles/eos_designs/python_modules/network_services/utils.py
Outdated
Show resolved
Hide resolved
…s/network_services/utils.py
ClausHolbechArista
added
the
one approval
carlbuchmann
approved these changes
Feb 1, 2024
carlbuchmann
removed
the
one approval
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
In the current implementation, when there is no policy defined under
wan_virtual_topology.vrfsfor VRF default. AVD will raise an error.This PR replaces this behavior with auto configuring a policy with one default statement (
default_virtual_topology) matching all local path_groups in the load balance policy.Of course, because it is VRF default, the Control plane special virtual topology is still injected.
Component(s) name
arista.avd.eos_designsProposed changes
When the VRF default is missing from
wan_virtual_topology.vrfs, AVD creates a policy calledDEFAULT-AVT-POLICYthat is configured with one default statement to match all traffic using all locally available path-groupsHow to test
molecule updated to test it in AutoVPN use case.
Checklist
Repository Checklist